Start using file_util symlink code, now that it's available.

Start using file_util symlink code, now that it's available.

In CL http://codereview.chromium.org/5349007
I added some base API for manipulating symlinks (since I needed it for some ChromeOS code and noticed that other places could use it too), and this just starts using that API.

BUG=none
TEST=Ran ui_tests, passed trybots.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68181

[Evan Martin, 2010-11-30 21:09:29]

LGTM

http://codereview.chromium.org/5286010/diff/1/base/base_paths_linux.cc
File base/base_paths_linux.cc (left):

http://codereview.chromium.org/5286010/diff/1/base/base_paths_linux.cc#oldcode42
base/base_paths_linux.cc:42: if (bin_dir_size < 0 || bin_dir_size > PATH_MAX) {
It seems the new code loses the >PATH_MAX check.  Do we care?

http://codereview.chromium.org/5286010/diff/1/base/base_paths_linux.cc#oldcode42
base/base_paths_linux.cc:42: if (bin_dir_size < 0 || bin_dir_size > PATH_MAX) {
It seems the new code loses the >PATH_MAX check.  Do we care?

http://codereview.chromium.org/5286010/diff/1/base/command_line.cc
File base/command_line.cc (right):

http://codereview.chromium.org/5286010/diff/1/base/command_line.cc#newcode242
base/command_line.cc:242: FilePath
self_exe(FILE_PATH_LITERAL("/proc/self/exe"));
FILE_PATH_LITERAL unnecessary.  (This code will only ever work on Linux.)

[Greg Spencer (Chromium), 2010-11-30 22:15:06]

http://codereview.chromium.org/5286010/diff/1/base/base_paths_linux.cc
File base/base_paths_linux.cc (left):

http://codereview.chromium.org/5286010/diff/1/base/base_paths_linux.cc#oldcode42
base/base_paths_linux.cc:42: if (bin_dir_size < 0 || bin_dir_size > PATH_MAX) {
On 2010/11/30 21:09:30, Evan Martin wrote:
> It seems the new code loses the >PATH_MAX check.  Do we care?

I don't think we do.  If readlink is saying it copied more bytes into the buffer
than the value supplied to it for the size of the buffer, then that's a pretty
serious bug in readlink, I think.

Also, readlink doesn't NULL terminate, so there's no reason to make the buffer
PATH_MAX + 1.

http://codereview.chromium.org/5286010/diff/1/base/command_line.cc
File base/command_line.cc (right):

http://codereview.chromium.org/5286010/diff/1/base/command_line.cc#newcode242
base/command_line.cc:242: FilePath
self_exe(FILE_PATH_LITERAL("/proc/self/exe"));
On 2010/11/30 21:09:30, Evan Martin wrote:
> FILE_PATH_LITERAL unnecessary.  (This code will only ever work on Linux.)

Removed.

[mattm, 2010-11-30 23:50:55]

lgtm