Suppress a data race on net::URLRequestThrottlerEntryInterface reference coun...

Suppress a data race on net::URLRequestThrottlerEntryInterface reference counter
BUG=64501
TBR=glider
TEST=TSan/UI should go greener

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67458

[Alexander Potapenko, 2010-11-29 14:37:16]

So the race doesn't occur on the constructor, i.e.
base::RefCounted<net::URLRequestThrottlerEntryInterface>() ?

On Fri, Nov 26, 2010 at 7:40 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Suppress a data race on net::URLRequestThrottlerEntryInterface reference
> counter
> BUG=64501
> TBR=glider
> TEST=TSan/UI should go greener
>
> Please review this at http://codereview.chromium.org/5284005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/tsan/suppressions.txt
>
>
> Index: tools/valgrind/tsan/suppressions.txt
> ===================================================================
> --- tools/valgrind/tsan/suppressions.txt        (revision 67447)
> +++ tools/valgrind/tsan/suppressions.txt        (working copy)
> @@ -116,6 +116,13 @@
>   fun:base::RefCounted<net::NetLog::EventParameters>::*
>  }
>
> +{
> +  bug_64501
> +  ThreadSanitizer:Race
> +  ...
> +  fun:base::RefCounted<net::URLRequestThrottlerEntryInterface>::*
> +}
> +
>  ############################
>  # Benign races
>  {
>
>
>

[Alexander Potapenko, 2010-11-29 16:56:37]

Discussed offline
LGTM

On Mon, Nov 29, 2010 at 5:35 PM, Alexander Potapenko
<glider@chromium.org> wrote:
> So the race doesn't occur on the constructor, i.e.
> base::RefCounted<net::URLRequestThrottlerEntryInterface>() ?
>
> On Fri, Nov 26, 2010 at 7:40 PM,  <timurrrr@chromium.org> wrote:
>> Reviewers: Alexander Potapenko,
>>
>> Description:
>> Suppress a data race on net::URLRequestThrottlerEntryInterface reference
>> counter
>> BUG=64501
>> TBR=glider
>> TEST=TSan/UI should go greener
>>
>> Please review this at http://codereview.chromium.org/5284005/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>  M     tools/valgrind/tsan/suppressions.txt
>>
>>
>> Index: tools/valgrind/tsan/suppressions.txt
>> ===================================================================
>> --- tools/valgrind/tsan/suppressions.txt        (revision 67447)
>> +++ tools/valgrind/tsan/suppressions.txt        (working copy)
>> @@ -116,6 +116,13 @@
>>   fun:base::RefCounted<net::NetLog::EventParameters>::*
>>  }
>>
>> +{
>> +  bug_64501
>> +  ThreadSanitizer:Race
>> +  ...
>> +  fun:base::RefCounted<net::URLRequestThrottlerEntryInterface>::*
>> +}
>> +
>>  ############################
>>  # Benign races
>>  {
>>
>>
>>
>