Issue 5284004: Revert "cashew: do not delete DBus::ObjectProxy objects from D-Bus callbacks"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5284004: Revert "cashew: do not delete DBus::ObjectProxy objects from D-Bus callbacks" (Closed)

Created:
10 years, 1 month ago by Vince Laviano

Modified:
9 years ago

Reviewers:
Daniel Kurtz

CC:
chromium-os-reviews_chromium.org, Vince Laviano

Base URL:
ssh://git@gitrw.chromium.org:9222/cashew.git@master

Visibility:
Public.

Description

Revert "cashew: do not delete DBus::ObjectProxy objects from D-Bus callbacks" This reverts commit 35386a9949355d796f2b195b0577e5a39fe72477. Reverting this CL in preparation for a more comprehensive CL that will also address the DBus::ObjectProxy creation case, which can also trigger a deadlock if done in a D-Bus callback. Change-Id: Ic60a1eb517b1cd76997aa3f8e00b42c44eeb018c BUG=chromium-os:8892 TEST=emerge cashew Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ad77e9f

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -247 lines)			Patch
M	src/cashew_server.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	src/cashew_server.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/main.cc	View	4 chunks	+2 lines, -5 lines	0 comments	Download
M	src/service.h	View	4 chunks	+0 lines, -28 lines	0 comments	Download
M	src/service.cc	View	4 chunks	+4 lines, -77 lines	0 comments	Download
M	src/service_manager.h	View	5 chunks	+2 lines, -38 lines	0 comments	Download
M	src/service_manager.cc	View	5 chunks	+12 lines, -87 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages