Chromium Code Reviews Chromium Code Reviews
Issue 5283002:
Addressing the comment in codereview.chromium.org/5151006. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/resources/offline_load.html |
| diff --git a/chrome/browser/resources/offline_load.html b/chrome/browser/resources/offline_load.html |
| index 1c1f002ea35ea9cda55a57e5bf23acd20ed04228..2826dcf952e329cd4b8305bd1867ea95aaeb08d4 100644 |
| --- a/chrome/browser/resources/offline_load.html |
| +++ b/chrome/browser/resources/offline_load.html |
| @@ -18,29 +18,28 @@ body { |
| color-stop(0.50, rgb(255,255,255)) |
| ); |
| height: 100%; |
| - padding: 0px; |
| - margin: 0px; |
| + padding: 0; |
| + margin: 0; |
| display: -webkit-box; |
| -webkit-box-orient: horizontal; |
| -} |
| - |
| -#spacer { |
| - -webkit-box-flex: 0.5; |
| + -webkit-box-pack: center; |
| + visibility: hidden; |
| } |
| #error { |
| margin-top: 150px; |
| - font-size: 24px; |
| - -webkit-box-flex: 1; |
| + font-size: 16px; |
| display: -webkit-box; |
| + width : 800px; |
| + max-width: 80%; |
| -webkit-box-orient: horizontal; |
| - max-width : 800px; |
| - width: 80%; |
| } |
| #error img { |
| - margin-right: 10px; |
| vertical-align: middle; |
| + width: 96px; |
| + height: 96px; |
| + -webkit-margin-end: 10px; |
| -webkit-box-flex: 0; |
| } |
| @@ -49,18 +48,6 @@ body { |
| -webkit-box-flex: 1; |
| } |
| -#heading { |
| - font-weight: bold; |
| -} |
| - |
| -#msg { |
| - font-size: 16px; |
| -} |
| - |
| -#msg_box a { |
| - font-size: 16px; |
| -} |
| - |
| </style> |
| <script> |
| function sendCommand(cmd) { |
| @@ -73,19 +60,17 @@ function showPage() { |
| } |
| // Start the timer to show the page. |
| function startTimer(time) { |
| - // wait 2.5 seconds before showing 'load now', 'go back' button. |
| + // wait before showing 'load now', 'go back' button. |
| setTimeout('showPage()', time); |
|
arv (Not doing code reviews)
2010/11/24 19:40:59
Don't use a string as the first argument to setTim
oshima
2010/11/24 21:30:11
Done.
|
| } |
| </script> |
| </head> |
| -<body oncontextmenu="return false;" jsvalues="onload:on_load"> |
| -<div id="spacer"> </div> |
| -<div id="error" jsvalues=".title:url"> |
| - <img i18n-values=".src:icon;.style.display:display_icon" |
| - width="96" height="96"> |
| +<body oncontextmenu="return false;" i18n-values="onload:on_load"> |
|
oshima
2010/11/23 20:45:14
I haven't change this. Please let me know your rec
arv (Not doing code reviews)
2010/11/24 19:40:59
Looking at the C++
The code it injected is "start
oshima
2010/11/24 21:30:11
Done. Thank you for the suggestion. It looks much
|
| +<div id="error" i18n-values=".title:url"> |
| + <img i18n-values=".src:icon;.style.display:display_icon"> |
| <div id="msg_box"> |
| - <div id="headling" i18n-values=".innerText:heading"></div> |
| + <h3 i18n-content="heading"></h3> |
| <div id="msg" i18n-values=".innerHTML:msg"></div> |
| <button id="continue_button" i18n-content="load_button" |
| @@ -101,6 +86,5 @@ function startTimer(time) { |
| </a> |
| </div> |
| </div> |
| -<div id="spacer"> </div> |
| </body> |
| </html> |
