Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 5281002: Fix --payload for optional stateful.tgz. (Closed)

Created:
10 years, 1 month ago by dgarrett
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Nick Sanders, ericli, DaleCurtis
Visibility:
Public.

Description

Fix --payload for optional stateful.tgz. Change-Id: I0af77b0ef83b016150aecdf6947182df8bad042d BUG=chromium-os:9492 TEST=Ran manually Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ee25e55

Patch Set 1 #

Patch Set 2 : Nit Fix #

Total comments: 6

Patch Set 3 : Fix comment nit. #

Patch Set 4 : Added warning if stateful.tgz missing for --payload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M autoupdate.py View 1 2 3 1 chunk +20 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgarrett
10 years, 1 month ago (2010-11-22 22:39:54 UTC) #1
sosa
http://codereview.chromium.org/5281002/diff/2001/autoupdate.py File autoupdate.py (right): http://codereview.chromium.org/5281002/diff/2001/autoupdate.py#newcode541 autoupdate.py:541: if os.path.dirname(src_path) != os.path.abspath(static_image_dir): The comment here is somewhat ...
10 years, 1 month ago (2010-11-23 00:49:41 UTC) #2
dgarrett
http://codereview.chromium.org/5281002/diff/2001/autoupdate.py File autoupdate.py (right): http://codereview.chromium.org/5281002/diff/2001/autoupdate.py#newcode541 autoupdate.py:541: if os.path.dirname(src_path) != os.path.abspath(static_image_dir): On 2010/11/23 00:49:42, sosa wrote: ...
10 years, 1 month ago (2010-11-23 01:30:27 UTC) #3
sosa
http://codereview.chromium.org/5281002/diff/2001/autoupdate.py File autoupdate.py (right): http://codereview.chromium.org/5281002/diff/2001/autoupdate.py#newcode545 autoupdate.py:545: if os.path.exists(src_stateful): It should always be there for an ...
10 years, 1 month ago (2010-11-23 01:51:10 UTC) #4
dgarrett
10 years, 1 month ago (2010-11-23 02:16:40 UTC) #5
http://codereview.chromium.org/5281002/diff/2001/autoupdate.py
File autoupdate.py (right):

http://codereview.chromium.org/5281002/diff/2001/autoupdate.py#newcode545
autoupdate.py:545: if os.path.exists(src_stateful):
On 2010/11/23 01:51:11, sosa wrote:
> It should always be there for an image that is a Developer or Test image. 
It's
> not necessary for non-dev/test images but these are rare except as release
> images.
> 
> On 2010/11/23 01:30:27, dgarrett wrote:
> > It's normal for it to be missing for some workflows. For example, in the
> > document "How to build and push an update locally".
> > 
> > On 2010/11/23 00:49:42, sosa wrote:
> > > I'm not really sure this should be optional.  Maybe at least print a
warning
> > > that it can't find it.
> > 
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698