Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 5281001: Ignore packages that cannot be found for the target. (Closed)

Created:
10 years, 1 month ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Ignore packages that cannot be found for the target. Change-Id: I1b08fe7fe292605543579af0df358cb2fcbf0b97 BUG=chromium-os:9493 TEST=Ran it with dev-utils/crosutils and chromeos-base/metrics

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M cros_run_unit_tests View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sosa
10 years, 1 month ago (2010-11-22 22:27:20 UTC) #1
petkov
LGTM w/ the comment below. http://codereview.chromium.org/5281001/diff/1/cros_run_unit_tests File cros_run_unit_tests (right): http://codereview.chromium.org/5281001/diff/1/cros_run_unit_tests#newcode77 cros_run_unit_tests:77: EBUILD_PATH=$( equery-${FLAGS_board} which ${package} ...
10 years, 1 month ago (2010-11-22 22:30:14 UTC) #2
sosa
PTAL Added extra logic to warn if missing package file and go to packages logic ...
10 years, 1 month ago (2010-11-22 22:34:43 UTC) #3
petkov
10 years, 1 month ago (2010-11-22 22:36:16 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698