Issue 528003: Using the root codereview.settings seems to be a problem for NACL...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 528003: Using the root codereview.settings seems to be a problem for NACL... (Closed)

Created:
10 years, 11 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Using the root codereview.settings seems to be a problem for NACL (there isn't one in their repo). They've been manually specifying --host etc for over a week. Why the change in behavior? BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35814

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	trychange.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

I don't recall exactly why.

lgtm

Expand Messages | Collapse Messages