Chromium Code Reviews Chromium Code Reviews
Issue 5278012:
EnumerateModules: Address UI review comments.... (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src/| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <html i18n-values="dir:textdirection;"> | 2 <html i18n-values="dir:textdirection;"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <style> | 5 <style> |
| 6 body { | 6 body { |
| 7 margin: 10px; | 7 margin: 10px; |
| 8 min-width: 47em; | 8 min-width: 47em; |
| 9 } | 9 } |
| 10 | 10 |
| (...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 121 font-weight: bold; | 121 font-weight: bold; |
| 122 } | 122 } |
| 123 | 123 |
| 124 .no-modules { | 124 .no-modules { |
| 125 margin: 6em 0 0; | 125 margin: 6em 0 0; |
| 126 text-align: center; | 126 text-align: center; |
| 127 font-size: 1.2em; | 127 font-size: 1.2em; |
| 128 } | 128 } |
| 129 | 129 |
| 130 .suspected-bad { | 130 .suspected-bad { |
| 131 color: orange; | 131 color: #DD7700; |
| 132 } | 132 } |
| 133 | 133 |
| 134 .confirmed-bad { | 134 .confirmed-bad { |
| 135 color: red; | 135 color: red; |
| 136 } | 136 } |
| 137 </style> | 137 </style> |
| 138 <script> | 138 <script> |
| 139 | 139 |
| 140 /** | 140 /** |
| 141 * This variable structure is here to document the structure that the template | 141 * This variable structure is here to document the structure that the template |
| (...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 224 </div> | 224 </div> |
| 225 </div> | 225 </div> |
| 226 | 226 |
| 227 <div class="content"> | 227 <div class="content"> |
| 228 <div class="module-name no-modules" | 228 <div class="module-name no-modules" |
| 229 jsdisplay="moduleList.length === 0"> | 229 jsdisplay="moduleList.length === 0"> |
| 230 <div i18n-content="modulesNoneLoaded">NO_MODULES_ARE_AVAILABLE</div> | 230 <div i18n-content="modulesNoneLoaded">NO_MODULES_ARE_AVAILABLE</div> |
| 231 </div> | 231 </div> |
| 232 | 232 |
| 233 <div jsdisplay="moduleList.length > 0"> | 233 <div jsdisplay="moduleList.length > 0"> |
| 234 <div class="module" jsselect="moduleList"> | 234 <table width="100%" cellpadding="0" cellspacing="0"> |
| 235 <table width="100%" cellpadding="0" cellspacing="0"> | 235 <tr class="module-loaded"> |
| 236 <tr class="module-loaded"> | 236 <td valign="top"> |
| 237 <td valign="top"> | 237 <table cellpadding="2" cellspacing="0" border="0"> |
| 238 <table cellpadding="2" cellspacing="0"> | 238 <tr jsselect="moduleList"> |
| 239 <tr> | 239 <td valign="top"><span dir="ltr" jsvalues=".innerHTML:description">< /span></div> |
| 240 <td colspan="2"><span class="module-name" dir="ltr" | 240 <span jsdisplay="status == 2 || status == 3"><br><nobr> |
|
Nico
2010/11/26 17:54:36
can use use css instead of <br> tags for vertical
| |
| 241 jscontent="name">NAME</span> | 241 <span jsdisplay="status == 2" |
| 242 <span dir="ltr" | 242 i18n-content="moduleSuspectedBad" |
| 243 jsdisplay="type_description.length > 0" | 243 class="suspected-bad">SUSPECTED_BAD</span> |
| 244 >(<span dir="ltr" | 244 <span jsdisplay="status == 3" |
| 245 jscontent="type_description">MODULE_TYPE</ span | 245 i18n-content="moduleConfirmedBad" |
| 246 >)</span> | 246 class="confirmed-bad">CONFIRMED_BAD</span> |
| 247 </td> | 247 <a jsdisplay="help_url.length > 0" |
|
Nico
2010/11/26 17:54:36
do you need to escape the >, i.e. >? ( http://h
| |
| 248 </tr> | 248 jsvalues=".href:help_url"><span |
|
Nico
2010/11/26 17:54:36
dedent 3?
| |
| 249 <tr> | 249 i18n-content="helpCenterLink">HELP_CENTER</span></a></ nobr> |
| 250 <td width="75"><span i18n-content="headerSoftware" /></td> | 250 <span jsdisplay="possibleResolution.length > 0"><br> |
| 251 <td><span dir="ltr" jsvalues=".innerHTML:description"></span> | 251 <span jscontent="possibleResolution">POSSIBLE_RESOLUTION</span>< /span><br><br></span> |
| 252 <span dir="ltr" jsdisplay="version.length > 0"> - </span> | 252 </td> |
| 253 <span dir="ltr" jscontent="version">VERSION</span></td> | 253 <td valign="top"><nobr><span dir="ltr" jscontent="digital_signer">SI GNER</span></nobr></td> |
| 254 </tr> | 254 <td valign="top"><span dir="ltr" jscontent="version">VERSION</span>< /td> |
| 255 <tr jsdisplay="digital_signer.length > 0"> | 255 <td valign="top"><span dir="ltr" |
| 256 <td><span i18n-content="headerSignedBy" /></td> | 256 jscontent="location">LOCATION</span><strong>< span |
| 257 <td><span dir="ltr" jscontent="digital_signer">SIGNER</span></td> | 257 dir="ltr" jscontent="name">NAME</span></strong> |
| 258 </tr> | 258 <span dir="ltr" |
| 259 <tr> | 259 jsdisplay="type_description.length > 0" |
| 260 <td><span i18n-content="headerLocation" /></td> | 260 >(<span dir="ltr" |
| 261 <td><span dir="ltr" | 261 jscontent="type_description">MODULE_TYPE</span |
| 262 jscontent="location">LOCATION</span><span | 262 >)</span> |
| 263 dir="ltr" jscontent="name">NAME</span></td> | 263 </td> |
| 264 </tr> | 264 </tr> |
| 265 <tr jsdisplay="status == 2 || status == 3"> | |
| 266 <td><span i18n-content="headerWarning" /></td> | |
| 267 <td><span jsdisplay="status == 2" | |
| 268 i18n-content="moduleSuspectedBad" | |
| 269 class="suspected-bad">SUSPECTED_BAD</span> | |
| 270 <span jsdisplay="status == 3" | |
| 271 i18n-content="moduleConfirmedBad" | |
| 272 class="confirmed-bad">CONFIRMED_BAD</span> | |
| 273 <a jsdisplay="help_url.length > 0" | |
| 274 jsvalues=".href:help_url"><span | |
| 275 i18n-content="helpCenterLink">HELP_CENTER</span></a> | |
| 276 </td> | |
| 277 </tr> | |
| 278 <tr jsdisplay="possibleResolution.length > 0"> | |
| 279 <td><span i18n-content="headerHelpTip" /></td> | |
| 280 <td><span | |
| 281 jscontent="possibleResolution">POSSIBLE_RESOLUTION</span></td> | |
| 282 </tr> | |
| 283 </table> | |
| 284 | |
| 285 </td> | |
| 286 </tr> | |
| 287 </table> | 265 </table> |
| 288 </div> | 266 </td> |
| 267 </tr> | |
| 268 </table> | |
| 289 </div> | 269 </div> |
| 290 </div> | 270 </div> |
| 291 </div> | 271 </div> |
| 292 </div> | 272 </div> |
| 293 </body> | 273 </body> |
| 294 </html> | 274 </html> |
| OLD | NEW |
