Issue 5278010: Reconfigure to use ssh connection rather than use different manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5278010: Reconfigure to use ssh connection rather than use different manifest. (Closed)

Created:
10 years, 1 month ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
scottz

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Reconfigure to use ssh connection rather than use different manifest. This also removes the rw_checkout var as it's not longer changes the affect of whether we use the ssh url or not. Note that this replaces the other CL from last night because the other CL didn't work. The other CL still pulled in the same manifest that has http: url's for each git repo. I reverted that change last night after I noticed this. Change-Id: I3d4ad2be6887ac2cf4ed2009bad9cae6dfdf5bbf BUG=chromium-os:9509 TEST=Ran with cbuildbot --clobber and incremental Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5643735

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix 80 char #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -18 lines)			Patch
	M	bin/cbuildbot.py	View		3 chunks	+8 lines, -15 lines	0 comments	Download
	M	bin/cros_repo_sync_all.py	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottz

10 years ago (2010-11-29 17:47:16 UTC) #2

LGTM, just fix the >80

http://codereview.chromium.org/5278010/diff/1/bin/cros_repo_sync_all.py
File bin/cros_repo_sync_all.py (right):

http://codereview.chromium.org/5278010/diff/1/bin/cros_repo_sync_all.py#newco...
bin/cros_repo_sync_all.py:31: cbuildbot._IncrementalCheckout(options.buildroot,
retries=_NUMBER_OF_RETRIES)
>80

Expand Messages | Collapse Messages