Issue 5278006: GPU thread acknowledges an armed watchdog every time it returns to the messag...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5278006: GPU thread acknowledges an armed watchdog every time it returns to the messag... (Closed)

Created:
10 years, 1 month ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GPU thread acknowledges an armed watchdog every time it returns to the message loop. It used to only acknowledge upon receiving a particular kind of Task from the watchdog, which could potentially be delayed by other Tasks. TEST=WebGL locally, check recovery from about:gpuhang locally, try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67184

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -14 lines)			Patch
	M	chrome/gpu/gpu_watchdog_thread.h	View	1	2 chunks	+24 lines, -1 line	0 comments	Download
	M	chrome/gpu/gpu_watchdog_thread.cc	View		4 chunks	+65 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

10 years, 1 month ago (2010-11-23 23:03:12 UTC) #2

LGTM

http://codereview.chromium.org/5278006/diff/1/chrome/gpu/gpu_watchdog_thread.h
File chrome/gpu/gpu_watchdog_thread.h (right):

http://codereview.chromium.org/5278006/diff/1/chrome/gpu/gpu_watchdog_thread....
chrome/gpu/gpu_watchdog_thread.h:55: bool armed_;
This should probably be volatile.

Expand Messages | Collapse Messages