Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 5278003: Fix crashes during GC caused by partially initialized objects. The... (Closed)

Created:
10 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix crashes during GC caused by partially initialized objects. The inline allocation code used the expected number of properties to calculate the number of inobject properties for an object instead of getting the actual number from the initial map. It is safer to use the inobject property count from the initial map in any case because that is the amount the instances will get. I think this disconnect got introduced when adding shrinking of objects. Unfortuntely I haven't been able to create a simple reproduction for a test case but this fixes the webpage that exhibits the crash. I'll see if I can create a reproduction tomorrow. Committed: http://code.google.com/p/v8/source/detail?r=5879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M src/arm/stub-cache-arm.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +3 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +3 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 1 month ago (2010-11-23 16:53:06 UTC) #1
Søren Thygesen Gjesse
10 years, 1 month ago (2010-11-23 22:31:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698