Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: src/assembler.cc

Issue 5277007: RelocInfo: fix source position decoding. (Closed)
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 ReadTaggedPC(); 343 ReadTaggedPC();
344 if (SetMode(RelocInfo::EMBEDDED_OBJECT)) return; 344 if (SetMode(RelocInfo::EMBEDDED_OBJECT)) return;
345 } else if (tag == kCodeTargetTag) { 345 } else if (tag == kCodeTargetTag) {
346 ReadTaggedPC(); 346 ReadTaggedPC();
347 if (SetMode(RelocInfo::CODE_TARGET)) return; 347 if (SetMode(RelocInfo::CODE_TARGET)) return;
348 } else if (tag == kPositionTag) { 348 } else if (tag == kPositionTag) {
349 ReadTaggedPC(); 349 ReadTaggedPC();
350 Advance(); 350 Advance();
351 // Check if we want source positions. 351 // Check if we want source positions.
352 if (mode_mask_ & RelocInfo::kPositionMask) { 352 if (mode_mask_ & RelocInfo::kPositionMask) {
353 // Check if we want this type of source position. 353 ReadTaggedData();
354 if (SetMode(DebugInfoModeFromTag(GetPositionTypeTag()))) { 354 if (SetMode(DebugInfoModeFromTag(GetPositionTypeTag()))) return;
355 // Finally read the data before returning.
356 ReadTaggedData();
357 return;
358 }
359 } 355 }
360 } else { 356 } else {
361 ASSERT(tag == kDefaultTag); 357 ASSERT(tag == kDefaultTag);
362 int extra_tag = GetExtraTag(); 358 int extra_tag = GetExtraTag();
363 if (extra_tag == kPCJumpTag) { 359 if (extra_tag == kPCJumpTag) {
364 int top_tag = GetTopTag(); 360 int top_tag = GetTopTag();
365 if (top_tag == kVariableLengthPCJumpTopTag) { 361 if (top_tag == kVariableLengthPCJumpTopTag) {
366 AdvanceReadVariableLengthPCJump(); 362 AdvanceReadVariableLengthPCJump();
367 } else { 363 } else {
368 AdvanceReadPC(); 364 AdvanceReadPC();
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
847 } 843 }
848 844
849 current_position_recording_type_ = NORMAL_POSITION; 845 current_position_recording_type_ = NORMAL_POSITION;
850 846
851 // Return whether something was written. 847 // Return whether something was written.
852 return written; 848 return written;
853 } 849 }
854 850
855 851
856 } } // namespace v8::internal 852 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698