Issue 5277007: RelocInfo: fix source position decoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5277007: RelocInfo: fix source position decoding. (Closed)

Created:
10 years ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

RelocInfo: fix source position decoding. We used to rely on reading both POSITION and STATEMENT_POSITION to get correct decoding of positions. This was error prone and made liveedit unhappy. Committed: http://code.google.com/p/v8/source/detail?r=5905

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -8 lines)			Patch
M	src/assembler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/SConscript	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/cctest/test-reloc-info.cc	View	1 chunk	+109 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages