Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: net/url_request/url_request_throttler_entry.cc

Issue 5276007: Implement exponential back-off mechanism. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: pull latest to merge Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/url_request/url_request_throttler_entry.h"
6
7 #include <cmath>
8
9 #include "base/logging.h"
10 #include "base/rand_util.h"
11 #include "base/string_number_conversions.h"
12 #include "net/url_request/url_request_throttler_header_interface.h"
13
14 namespace net {
15
16 const int URLRequestThrottlerEntry::kDefaultSlidingWindowPeriodMs = 2000;
17 const int URLRequestThrottlerEntry::kDefaultMaxSendThreshold = 20;
18 const int URLRequestThrottlerEntry::kDefaultInitialBackoffMs = 700;
19 const int URLRequestThrottlerEntry::kDefaultAdditionalConstantMs = 100;
20 const double URLRequestThrottlerEntry::kDefaultMultiplyFactor = 1.4;
21 const double URLRequestThrottlerEntry::kDefaultJitterFactor = 0.4;
22 const int URLRequestThrottlerEntry::kDefaultMaximumBackoffMs = 60 * 60 * 1000;
23 const int URLRequestThrottlerEntry::kDefaultEntryLifetimeMs = 120000;
24 const char URLRequestThrottlerEntry::kRetryHeaderName[] = "X-Retry-After";
25
26 URLRequestThrottlerEntry::URLRequestThrottlerEntry()
27 : sliding_window_period_(
28 base::TimeDelta::FromMilliseconds(kDefaultSlidingWindowPeriodMs)),
29 max_send_threshold_(kDefaultMaxSendThreshold),
30 initial_backoff_ms_(kDefaultInitialBackoffMs),
31 additional_constant_ms_(kDefaultAdditionalConstantMs),
32 multiply_factor_(kDefaultMultiplyFactor),
33 jitter_factor_(kDefaultJitterFactor),
34 maximum_backoff_ms_(kDefaultMaximumBackoffMs),
35 entry_lifetime_ms_(kDefaultEntryLifetimeMs) {
36 Initialize();
37 }
38
39 URLRequestThrottlerEntry::URLRequestThrottlerEntry(
40 int sliding_window_period_ms,
41 int max_send_threshold,
42 int initial_backoff_ms,
43 int additional_constant_ms,
44 double multiply_factor,
45 double jitter_factor,
46 int maximum_backoff_ms)
47 : sliding_window_period_(
48 base::TimeDelta::FromMilliseconds(sliding_window_period_ms)),
49 max_send_threshold_(max_send_threshold),
50 initial_backoff_ms_(initial_backoff_ms),
51 additional_constant_ms_(additional_constant_ms),
52 multiply_factor_(multiply_factor),
53 jitter_factor_(jitter_factor),
54 maximum_backoff_ms_(maximum_backoff_ms),
55 entry_lifetime_ms_(-1) {
56 DCHECK_GT(sliding_window_period_ms, 0);
57 DCHECK_GT(max_send_threshold_, 0);
58 DCHECK_GE(initial_backoff_ms_, 0);
59 DCHECK_GE(additional_constant_ms_, 0);
60 DCHECK_GT(multiply_factor_, 0);
61 DCHECK_GE(jitter_factor_, 0);
62 DCHECK_LT(jitter_factor_, 1);
63 DCHECK_GE(maximum_backoff_ms_, 0);
64
65 Initialize();
66 }
67
68 URLRequestThrottlerEntry::~URLRequestThrottlerEntry() {
69 }
70
71 void URLRequestThrottlerEntry::Initialize() {
72 // Since this method is called by the constructors, GetTimeNow() (a virtual
73 // method) is not used.
74 exponential_backoff_release_time_ = base::TimeTicks::Now();
75 failure_count_ = 0;
76 latest_response_was_failure_ = false;
77
78 sliding_window_release_time_ = base::TimeTicks::Now();
79 }
80
81 bool URLRequestThrottlerEntry::IsDuringExponentialBackoff() const {
82 return exponential_backoff_release_time_ > GetTimeNow();
83 }
84
85 int64 URLRequestThrottlerEntry::ReserveSendingTimeForNextRequest(
86 const base::TimeTicks& earliest_time) {
87 base::TimeTicks now = GetTimeNow();
88 // If a lot of requests were successfully made recently,
89 // sliding_window_release_time_ may be greater than
90 // exponential_backoff_release_time_.
91 base::TimeTicks recommended_sending_time =
92 std::max(std::max(now, earliest_time),
93 std::max(exponential_backoff_release_time_,
94 sliding_window_release_time_));
95
96 DCHECK(send_log_.empty() ||
97 recommended_sending_time >= send_log_.back());
98 // Log the new send event.
99 send_log_.push(recommended_sending_time);
100
101 sliding_window_release_time_ = recommended_sending_time;
102
103 // Drop the out-of-date events in the event list.
104 // We don't need to worry that the queue may become empty during this
105 // operation, since the last element is sliding_window_release_time_.
106 while ((send_log_.front() + sliding_window_period_ <=
107 sliding_window_release_time_) ||
108 send_log_.size() > static_cast<unsigned>(max_send_threshold_)) {
109 send_log_.pop();
110 }
111
112 // Check if there are too many send events in recent time.
113 if (send_log_.size() == static_cast<unsigned>(max_send_threshold_))
114 sliding_window_release_time_ = send_log_.front() + sliding_window_period_;
115
116 return (recommended_sending_time - now).InMillisecondsRoundedUp();
117 }
118
119 base::TimeTicks
120 URLRequestThrottlerEntry::GetExponentialBackoffReleaseTime() const {
121 return exponential_backoff_release_time_;
122 }
123
124 void URLRequestThrottlerEntry::UpdateWithResponse(
125 const URLRequestThrottlerHeaderInterface* response) {
126 if (response->GetResponseCode() >= 500) {
127 failure_count_++;
128 latest_response_was_failure_ = true;
129 exponential_backoff_release_time_ =
130 CalculateExponentialBackoffReleaseTime();
131 } else {
132 // We slowly decay the number of times delayed instead of resetting it to 0
133 // in order to stay stable if we received lots of requests with
134 // malformed bodies at the same time.
135 if (failure_count_ > 0)
136 failure_count_--;
137
138 latest_response_was_failure_ = false;
139
140 // The reason why we are not just cutting the release time to GetTimeNow()
141 // is on the one hand, it would unset delay put by our custom retry-after
142 // header and on the other we would like to push every request up to our
143 // "horizon" when dealing with multiple in-flight requests. Ex: If we send
144 // three requests and we receive 2 failures and 1 success. The success that
145 // follows those failures will not reset the release time, further requests
146 // will then need to wait the delay caused by the 2 failures.
147 exponential_backoff_release_time_ = std::max(
148 GetTimeNow(), exponential_backoff_release_time_);
149
150 std::string retry_header = response->GetNormalizedValue(kRetryHeaderName);
151 if (!retry_header.empty())
152 HandleCustomRetryAfter(retry_header);
153 }
154 }
155
156 bool URLRequestThrottlerEntry::IsEntryOutdated() const {
157 if (entry_lifetime_ms_ == -1)
158 return false;
159
160 base::TimeTicks now = GetTimeNow();
161
162 // If there are send events in the sliding window period, we still need this
163 // entry.
164 if (send_log_.size() > 0 &&
165 send_log_.back() + sliding_window_period_ > now) {
166 return false;
167 }
168
169 int64 unused_since_ms =
170 (now - exponential_backoff_release_time_).InMilliseconds();
171
172 // Release time is further than now, we are managing it.
173 if (unused_since_ms < 0)
174 return false;
175
176 // latest_response_was_failure_ is true indicates that the latest one or
177 // more requests encountered server errors or had malformed response bodies.
178 // In that case, we don't want to collect the entry unless it hasn't been used
179 // for longer than the maximum allowed back-off.
180 if (latest_response_was_failure_)
181 return unused_since_ms > std::max(maximum_backoff_ms_, entry_lifetime_ms_);
182
183 // Otherwise, consider the entry is outdated if it hasn't been used for the
184 // specified lifetime period.
185 return unused_since_ms > entry_lifetime_ms_;
186 }
187
188 void URLRequestThrottlerEntry::ReceivedContentWasMalformed() {
189 // For any response that is marked as malformed now, we have probably
190 // considered it as a success when receiving it and decreased the failure
191 // count by 1. As a result, we increase the failure count by 2 here to undo
192 // the effect and record a failure.
193 //
194 // Please note that this may lead to a larger failure count than expected,
195 // because we don't decrease the failure count for successful responses when
196 // it has already reached 0.
197 failure_count_ += 2;
198 latest_response_was_failure_ = true;
199 exponential_backoff_release_time_ = CalculateExponentialBackoffReleaseTime();
200 }
201
202 base::TimeTicks
203 URLRequestThrottlerEntry::CalculateExponentialBackoffReleaseTime() {
204 double delay = initial_backoff_ms_;
205 delay *= pow(multiply_factor_, failure_count_);
206 delay += additional_constant_ms_;
207 delay -= base::RandDouble() * jitter_factor_ * delay;
208
209 // Ensure that we do not exceed maximum delay.
210 int64 delay_int = static_cast<int64>(delay + 0.5);
211 delay_int = std::min(delay_int, static_cast<int64>(maximum_backoff_ms_));
212
213 return std::max(GetTimeNow() + base::TimeDelta::FromMilliseconds(delay_int),
214 exponential_backoff_release_time_);
215 }
216
217 base::TimeTicks URLRequestThrottlerEntry::GetTimeNow() const {
218 return base::TimeTicks::Now();
219 }
220
221 void URLRequestThrottlerEntry::HandleCustomRetryAfter(
222 const std::string& header_value) {
223 // Input parameter is the number of seconds to wait in a floating point value.
224 double time_in_sec = 0;
225 bool conversion_is_ok = base::StringToDouble(header_value, &time_in_sec);
226
227 // Conversion of custom retry-after header value failed.
228 if (!conversion_is_ok)
229 return;
230
231 // We must use an int value later so we transform this in milliseconds.
232 int64 value_ms = static_cast<int64>(0.5 + time_in_sec * 1000);
233
234 if (maximum_backoff_ms_ < value_ms || value_ms < 0)
235 return;
236
237 exponential_backoff_release_time_ = std::max(
238 (GetTimeNow() + base::TimeDelta::FromMilliseconds(value_ms)),
239 exponential_backoff_release_time_);
240 }
241
242 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_throttler_entry.h ('k') | net/url_request/url_request_throttler_entry_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698