Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 5273011: An experimental fix for Bug 64726... (Closed)

Created:
10 years ago by Hironori Bono
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

An experimental fix for Bug 64726 This change just adds a virtual destructor to TestRenderViewHost to see we can delete the objects created in its constructor. BUG=64726 TEST=make the "Chromium Mac (valgrind)" bot green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/renderer_host/test/test_render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
10 years ago (2010-11-30 05:45:14 UTC) #1
Elliot Glaysher
10 years ago (2010-11-30 17:31:55 UTC) #2
LGTM

On Mon, Nov 29, 2010 at 9:45 PM,  <hbono@chromium.org> wrote:
> Reviewers: Lei Zhang, Elliot Glaysher,
>
> Description:
> An experimental fix for Bug 64726
> This change just adds a virtual destructor to TestRenderViewHost to see we
> can
> delete the objects created in its constructor.
>
> BUG=64726
> TEST=make the "Chromium Mac (valgrind)" bot green.
>
> Please review this at http://codereview.chromium.org/5273011/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/renderer_host/test/test_render_view_host.h
>  M     chrome/browser/renderer_host/test/test_render_view_host.cc
>
>
> Index: chrome/browser/renderer_host/test/test_render_view_host.cc
> ===================================================================
> --- chrome/browser/renderer_host/test/test_render_view_host.cc  (revision
> 67654)
> +++ chrome/browser/renderer_host/test/test_render_view_host.cc  (working
> copy)
> @@ -105,6 +105,9 @@
>       is_showing_(false) {
>  }
>
> +TestRenderWidgetHostView::~TestRenderWidgetHostView() {
> +}
> +
>  gfx::Rect TestRenderWidgetHostView::GetViewBounds() const {
>   return gfx::Rect();
>  }
> Index: chrome/browser/renderer_host/test/test_render_view_host.h
> ===================================================================
> --- chrome/browser/renderer_host/test/test_render_view_host.h   (revision
> 67654)
> +++ chrome/browser/renderer_host/test/test_render_view_host.h   (working
> copy)
> @@ -49,6 +49,7 @@
>  class TestRenderWidgetHostView : public RenderWidgetHostView {
>  public:
>   explicit TestRenderWidgetHostView(RenderWidgetHost* rwh);
> +  virtual ~TestRenderWidgetHostView();
>
>   virtual void InitAsPopup(RenderWidgetHostView* parent_host_view,
>                            const gfx::Rect& pos) {}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698