Add "create Application Shortcut" to the app menu on NTP.

Add "create Application Shortcut" to the app menu on NTP.

BUG=52451
TEST=Manually create app shortcuts for urls and apps.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67664

[Sam Kerner (Chrome), 2010-11-29 05:22:23]

This CL adds Chrome app shortcut creation for windows and linux views.  Working
on GTK as a separate change.

[Sam Kerner (Chrome), 2010-11-29 23:51:44]

On 2010/11/29 05:22:23, Sam Kerner (Chrome) wrote:
> This CL adds Chrome app shortcut creation for windows and linux views. 
Working
> on GTK as a separate change.

Changed my mind, and added GTK changes to this CL.

[Aaron Boodman, 2010-11-30 00:29:28]

In the screen shots, the icon in the shortcut dialog looks too small and
off-center. Why is that?

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/dom_ui/app_l...
File chrome/browser/dom_ui/app_launcher_handler.cc (right):

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/dom_ui/app_l...
chrome/browser/dom_ui/app_launcher_handler.cc:339: DCHECK(extension);
My new motto: DCHECK is for wusses. In this case, this cannot happen if the code
is correct, so CHECK.

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_prefs.cc (right):

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/extensions/e...
chrome/browser/extensions/extension_prefs.cc:570: LaunchType result;
Nit: Always initialize primitives.

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/gtk/create_a...
File chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h (right):

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/gtk/create_a...
chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h:27: friend class
BrowserThread;
I usually see friend declarations inside a private: block.

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
File chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc (right):

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc:327: void
CreateChromeApplicationShortcutsDialogGtk::OnCreatedShortcut() {}
Shouldn't there be something in this?

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
File chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h (right):

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h:27: friend class
BrowserThread;
I usually see friend declarations inside private blocks in Chrome.

[Sam Kerner (Chrome), 2010-11-30 01:11:50]

On 2010/11/30 00:29:28, Aaron Boodman wrote:
> In the screen shots, the icon in the shortcut dialog looks too small and
> off-center. Why is that?

The shortcut icon is defined to be 32x32 by the existing code.  I did not touch
the code that places the icons.  It does look off on windows...  Will look into
why.

I had assumed 32x32 was the standard size of an icon, and the icon in the dialog
should match the icon we create on the desktop.  Should have googled it: Windows
XP docs recommend 48x48.  Or, I can make the icon in the dialog box full sized,
and shrink it when making the icon.  Your call.

[Sam Kerner (Chrome), 2010-11-30 01:21:04]

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/dom_ui/app_l...
File chrome/browser/dom_ui/app_launcher_handler.cc (right):

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/dom_ui/app_l...
chrome/browser/dom_ui/app_launcher_handler.cc:339: DCHECK(extension);
On 2010/11/30 00:29:28, Aaron Boodman wrote:
> My new motto: DCHECK is for wusses. In this case, this cannot happen if the
code
> is correct, so CHECK.

Done.

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_prefs.cc (right):

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/extensions/e...
chrome/browser/extensions/extension_prefs.cc:570: LaunchType result;
On 2010/11/30 00:29:28, Aaron Boodman wrote:
> Nit: Always initialize primitives.

Done.

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/gtk/create_a...
File chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h (right):

http://codereview.chromium.org/5273004/diff/18025/chrome/browser/gtk/create_a...
chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h:27: friend class
BrowserThread;
On 2010/11/30 00:29:28, Aaron Boodman wrote:
> I usually see friend declarations inside a private: block.

Done.

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
File chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc (right):

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc:327: void
CreateChromeApplicationShortcutsDialogGtk::OnCreatedShortcut() {}
On 2010/11/30 00:29:28, Aaron Boodman wrote:
> Shouldn't there be something in this?

The superclass calls OnCreatedShortcut() after a shortcut is created.  The old
URL shortcuts open the app.  The new chrome app shortcuts do not, so there is
nothing to do.

I chose to not open the app because the user is on the NTP.  If they want to
open the app, they can click on the icon.  For URL shortcuts, the only way to
open them is to find the icon that was created and click it, so opening the app
makes more sense.

I changed OnCreated() to not be pure virtual, so that the empty method is not
needed.

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
File chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h (right):

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h:27: friend class
BrowserThread;
On 2010/11/30 00:29:28, Aaron Boodman wrote:
> I usually see friend declarations inside private blocks in Chrome.

Done.

[Aaron Boodman, 2010-11-30 01:30:47]

lgtm

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
File chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc (right):

http://codereview.chromium.org/5273004/diff/21001/chrome/browser/gtk/create_a...
chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc:327: void
CreateChromeApplicationShortcutsDialogGtk::OnCreatedShortcut() {}
On 2010/11/30 01:21:04, Sam Kerner (Chrome) wrote:
> On 2010/11/30 00:29:28, Aaron Boodman wrote:
> > Shouldn't there be something in this?
> 
> The superclass calls OnCreatedShortcut() after a shortcut is created.  The old
> URL shortcuts open the app.  The new chrome app shortcuts do not, so there is
> nothing to do.
> 
> I chose to not open the app because the user is on the NTP.  If they want to
> open the app, they can click on the icon.  For URL shortcuts, the only way to
> open them is to find the icon that was created and click it, so opening the
app
> makes more sense.
> 
> I changed OnCreated() to not be pure virtual, so that the empty method is not
> needed.

Ah, I agree.

In that case, the correct style I think is to put a newline between the two
braces.