Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5205)

Unified Diff: chrome/test/data/extensions/api_test/omnibox/test.html

Issue 5271009: Replace 'descriptionStyles' in omnibox API with a simple xml (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/omnibox/test.html
diff --git a/chrome/test/data/extensions/api_test/omnibox/test.html b/chrome/test/data/extensions/api_test/omnibox/test.html
index d66b6e729c25d2299b53fd1d2cf29e9919df872e..50e5d4f11597a3af4cb6fe80f89582f3cd0e8e1f 100644
--- a/chrome/test/data/extensions/api_test/omnibox/test.html
+++ b/chrome/test/data/extensions/api_test/omnibox/test.html
@@ -5,16 +5,12 @@ chrome.omnibox.onInputChanged.addListener(
if (text != "suggestio")
return;
- var desc = 'Description with style: <match>, [dim], (url till end)';
+ var desc = 'Description with style: <match>&lt;match&gt;</match>, ' +
Matt Perry 2010/11/29 22:06:52 hmm.. one disadvantage of this change is that desc
Aaron Boodman 2010/11/30 01:13:57 True, but that is not too hard to do.
+ '<dim>[dim]</dim>, <url>(url till end)</url>';
suggest([
{
content: text + "n1",
- description: desc,
- descriptionStyles: [
- chrome.omnibox.styleMatch(desc.indexOf('<'), 6),
- chrome.omnibox.styleDim(desc.indexOf('['), 4),
- chrome.omnibox.styleUrl(desc.indexOf('(')),
- ]
+ description: desc
},
{content: text + "n2", description: "description2"},
{content: text + "n3", description: "description3"},

Powered by Google App Engine
This is Rietveld 408576698