Replace 'descriptionStyles' in omnibox API with a simple xml

Replace 'descriptionStyles' in omnibox API with a simple xml
syntax. This should make it a bit easier to use.

BUG=64539
TEST=n/a

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67687

[Matt Perry, 2010-11-29 22:06:51]

mostly LG, a few questions

chrome_search still needs to be changed

http://codereview.chromium.org/5271009/diff/1/chrome/common/extensions/api/ex...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/5271009/diff/1/chrome/common/extensions/api/ex...
chrome/common/extensions/api/extension_api.json:3961: "type": "object",
why this change?

http://codereview.chromium.org/5271009/diff/1/chrome/renderer/resources/exten...
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/5271009/diff/1/chrome/renderer/resources/exten...
chrome/renderer/resources/extension_process_bindings.js:351: for (var i = 0; i <
userSuggestions.length; i++) {
maybe we should run the sendSuggestions validator before this, to give
reasonable error messages

http://codereview.chromium.org/5271009/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/omnibox/test.html (right):

http://codereview.chromium.org/5271009/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/omnibox/test.html:8: var desc =
'Description with style: <match>&lt;match&gt;</match>, ' +
hmm.. one disadvantage of this change is that descriptions from a remote source
will have to be scrubbed for < and > and &.

[Aaron Boodman, 2010-11-30 01:13:57]

http://codereview.chromium.org/5271009/diff/1/chrome/common/extensions/api/ex...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/5271009/diff/1/chrome/common/extensions/api/ex...
chrome/common/extensions/api/extension_api.json:3961: "type": "object",
On 2010/11/29 22:06:52, Matt Perry wrote:
> why this change?

The items send to sendSuggestions() have an extra property (descriptionStyles)
not documented by SuggestResult, so validation barfs.

http://codereview.chromium.org/5271009/diff/1/chrome/renderer/resources/exten...
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/5271009/diff/1/chrome/renderer/resources/exten...
chrome/renderer/resources/extension_process_bindings.js:351: for (var i = 0; i <
userSuggestions.length; i++) {
On 2010/11/29 22:06:52, Matt Perry wrote:
> maybe we should run the sendSuggestions validator before this, to give
> reasonable error messages

Done.

http://codereview.chromium.org/5271009/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/omnibox/test.html (right):

http://codereview.chromium.org/5271009/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/omnibox/test.html:8: var desc =
'Description with style: <match>&lt;match&gt;</match>, ' +
On 2010/11/29 22:06:52, Matt Perry wrote:
> hmm.. one disadvantage of this change is that descriptions from a remote
source
> will have to be scrubbed for < and > and &.

True, but that is not too hard to do.

[Aaron Boodman, 2010-11-30 01:14:21]

Oh, and regarding chrome_search, I'm going to update that with some other
changes all together.

[Matt Perry, 2010-11-30 01:17:31]

LGTM

http://codereview.chromium.org/5271009/diff/7001/chrome/renderer/resources/ex...
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/5271009/diff/7001/chrome/renderer/resources/ex...
chrome/renderer/resources/extension_process_bindings.js:764:
apiFunctions["omnibox.sendSuggestions"].updateArguments =
Will this validate against the incoming arguments, or the result of this
function? If it's the former, can we put this back to accepting a SuggestResult
in the api.json?

[Aaron Boodman, 2010-11-30 01:21:32]

On 2010/11/30 01:17:31, Matt Perry wrote:
> LGTM
> 
>
http://codereview.chromium.org/5271009/diff/7001/chrome/renderer/resources/ex...
> File chrome/renderer/resources/extension_process_bindings.js (right):
> 
>
http://codereview.chromium.org/5271009/diff/7001/chrome/renderer/resources/ex...
> chrome/renderer/resources/extension_process_bindings.js:764:
> apiFunctions["omnibox.sendSuggestions"].updateArguments =
> Will this validate against the incoming arguments, or the result of this
> function? If it's the former, can we put this back to accepting a
SuggestResult
> in the api.json?

It validates against the result of this function. See:
http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=chrome/renderer/resou...