UI Revamp + several fixes.

chrome/browser/resources/bug_report.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Constants.
 var FEEDBACK_LANDING_PAGE =
     'http://www.google.com/support/chrome/go/feedback_confirmation'
 
 var selectedThumbnailDivId = '';
 var selectedThumbnailId = '';
@@ skipping 34 matching lines @@
 function addScreenshot(divId, screenshot) {
   var thumbnailDiv = document.createElement('div');
   thumbnailDiv.className = 'image-thumbnail-container';
 
   thumbnailDiv.id = divId + '-thumbnailDiv-' + $(divId).children.length;
   thumbnailDiv.onclick = function() {
     selectImage(divId, thumbnailDiv.id);
   };
 
   var innerDiv = document.createElement('div');
-  innerDiv.className = 'image-thumbnail';
+  if (divId == 'current-screenshots')
+    innerDiv.className = 'image-thumbnail-current';
+  else
+    innerDiv.className = 'image-thumbnail';
 
   var thumbnail = document.createElement('img');
   thumbnail.id = thumbnailDiv.id + '-image';
   // We add the ?+timestamp to make sure the image URLs are unique
   // and Chrome does not load the image from cache.
   thumbnail.src = screenshot + "?" + Date.now();
   innerDiv.appendChild(thumbnail);
 
-  var largeImage = document.createElement('img');
-  largeImage.src = screenshot + "?" + Date.now();
-
-  var popupDiv = document.createElement('div');
-  popupDiv.appendChild(largeImage);
-  innerDiv.appendChild(popupDiv);
-
   thumbnailDiv.appendChild(innerDiv);
   $(divId).appendChild(thumbnailDiv);
 
   if (!selectedThumbnailId)
     selectImage(divId, thumbnailDiv.id);
 }
 
 /**
  * Send's the report; after the report is sent, we need to be redirected to
  * the landing page, but we shouldn't be able to navigate back, hence
  * we open the landing page in a new tab and sendReport closes this tab.
  */
 function sendReport() {
   if (!$('issue-with-combo').selectedIndex) {
     alert(localStrings.getString('no-issue-selected'));
     return false;
+  } else if ($('description-text').value.length == 0) {
+    alert(localStrings.getString('no-description'));
+    return false;
   }
 
   var imagePath = '';
   if (selectedThumbnailId)
     imagePath = $(selectedThumbnailId + '-image').src;
 
   // Note, categories are based from 1 in our protocol buffers, so no
   // adjustment is needed on selectedIndex.
+  var pageUrl = $('page-url-text').value;
+  if (!$('page-url-checkbox').checked)
+    pageUrl = "";
   var reportArray = [String($('issue-with-combo').selectedIndex),
-                     $('page-url-text').value,
+                     pageUrl,
                      $('description-text').value,
                      imagePath];
 
   // Add chromeos data if it exists.
   if ($('user-email-text') && $('sys-info-checkbox')) {
-    reportArray = reportArray.concat([$('user-email-text').value,
+    var userEmail= $('user-email-text').value;
+    if (!$('user-email-checkbox').checked)
+      userEmail = "";

[oshima, 2010/11/29 19:09:22]

single quote

[rkc, 2010/11/29 22:41:08]

Done.

+    reportArray = reportArray.concat([userEmail,
                                       String($('sys-info-checkbox').checked)]);
   }
 
   // open the landing page in a new tab, sendReport will close this one.
   window.open(FEEDBACK_LANDING_PAGE, '_blank');
   chrome.send('sendReport', reportArray);
   return true;
 }
 
 function cancel() {
@@ skipping 16 matching lines @@
 
   return true;
 }
 
 /**
  * Select the saved screenshots div, restoring the image that was
  * selected when we had this div open previously.
  */
 function savedSelected() {
   $('current-screenshots').style.display = 'none';
-  $('saved-screenshots').style.display = 'block';
 
-  if (selectedThumbnailDivId != 'saved-screenshots')
-    selectImage('saved-screenshots', savedThumbnailIds['saved-screenshots']);
+  if ($('saved-screenshots').childElementCount == 0) {
+    // setupSavedScreenshots will take care of changing visibility
+    chrome.send('refreshSavedScreenshots', []);
+  } else {
+    $('saved-screenshots').style.display = 'block';
+    if (selectedThumbnailDivId != 'saved-screenshots')
+      selectImage('saved-screenshots', savedThumbnailIds['saved-screenshots']);
+  }
 
   return true;
 }
 
 /**
  * Unselect all screenshots divs.
  */
 function noneSelected() {
   $('current-screenshots').style.display = 'none';
   if ($('saved-screenshots'))
     $('saved-screenshots').style.display = 'none';
 
   selectedThumbnailDivId = '';
   selectedThumbnailId = '';
   return true;
 }
+
+/**
+ * Toggle the type of screenshot we're showing to the user between
+ * the current screenshot, and a list of saved screenshots
+ */
+function toggleScreenshotType() {
+  // If we are showing the current screenshot, show the saved screenshots;
+  // otherwise, show the current screenshot. Update the text appropriately,
+  // the text is our marker to know what we are currently showing.
+  if ($('screenshot-label').innerHTML.indexOf(
+      localStrings.getString('current-screenshot')) > -1) {
+    // Switch to saved screenshots.  
+    $('screenshot-label').innerHTML = $('screenshot-label').innerHTML.replace(
+        localStrings.getString('current-screenshot'),
+        localStrings.getString('saved-screenshot'));
+
+    $('screenshot-link').innerHTML = $('screenshot-link').innerHTML.replace(
+        localStrings.getString('choose-different-screenshot'),
+        localStrings.getString('choose-original-screenshot'));

[oshima, 2010/11/29 19:09:22]

This looks a bit hacky. can't this be done via css (like altering visibility)?

[rkc, 2010/11/29 22:41:08]

Done.

+    
+    savedSelected();
+  } else {
+    // Go back to current screenshot.
+    $('screenshot-label').innerHTML = $('screenshot-label').innerHTML.replace(
+        localStrings.getString('saved-screenshot'),
+        localStrings.getString('current-screenshot'));
+    
+    $('screenshot-link').innerHTML = $('screenshot-link').innerHTML.replace(
+        localStrings.getString('choose-original-screenshot'),
+        localStrings.getString('choose-different-screenshot'));
+    
+    currentSelected();
+  }
+}