Issue 527029: Add BusConnection::gconnection() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527029: Add BusConnection::gconnection() function. (Closed)

Created:
10 years, 11 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
Sean Parent

CC:
chromium-os-reviews_googlegroups.com, satorux1

Visibility:
Public.

Description

Add BusConnection::g_connection() function, just like the Proxy class. This change is for http://codereview.chromium.org/521058.

Patch Set 2 : addressed the issue #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/common/chromeos/dbus/dbus.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sean Parent

Minor naming suggestion - either way, LGTM. http://codereview.chromium.org/527029/diff/1/2 File src/common/chromeos/dbus/dbus.h (right): http://codereview.chromium.org/527029/diff/1/2#newcode49 src/common/chromeos/dbus/dbus.h:49: const value_type& ...

10 years, 11 months ago (2010-01-08 17:58:04 UTC) #2

Yusuke Sato

10 years, 11 months ago (2010-01-09 11:13:48 UTC) #3

Thanks! Changed the name.
Submitting.

http://codereview.chromium.org/527029/diff/1/2
File src/common/chromeos/dbus/dbus.h (right):

http://codereview.chromium.org/527029/diff/1/2#newcode49
src/common/chromeos/dbus/dbus.h:49: const value_type& gconnection() const {
On 2010/01/08 17:58:04, Sean Parent wrote:
> To be consistent with the dbus naming conventions, I'd change this to
> g_connection().

Done.

Expand Messages | Collapse Messages

Issue 527029: Add BusConnection::gconnection() function. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed the issue #

Messages