Issue 527024: Linux: implement setting cursor type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527024: Linux: implement setting cursor type (Closed)

Created:
10 years, 11 months ago by Tristan Schmelcher 2

Modified:
9 years, 6 months ago

Reviewers:
Antoine Labour, piman

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Linux: implement setting cursor type Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35764

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -11 lines)			Patch
M	plugin/cross/o3d_glue.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	plugin/cross/o3d_glue.cc	View	1	5 chunks	+73 lines, -5 lines	0 comments	Download
M	plugin/linux/main_linux.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM. Minor comment. http://codereview.chromium.org/527024/diff/1/3 File plugin/cross/o3d_glue.cc (right): http://codereview.chromium.org/527024/diff/1/3#newcode893 plugin/cross/o3d_glue.cc:893: case o3d::Cursor::NONE: can you add NOTIMPLEMENTED() ...

10 years, 11 months ago (2010-01-08 00:44:33 UTC) #2

Tristan Schmelcher 2

10 years, 11 months ago (2010-01-08 01:13:27 UTC) #3

http://codereview.chromium.org/527024/diff/1/3
File plugin/cross/o3d_glue.cc (right):

http://codereview.chromium.org/527024/diff/1/3#newcode893
plugin/cross/o3d_glue.cc:893: case o3d::Cursor::NONE:
On 2010/01/08 00:44:33, piman wrote:
> can you add NOTIMPLEMENTED() here and below ?

Done.

Expand Messages | Collapse Messages

Issue 527024: Linux: implement setting cursor type (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages