Issue 527006: - Adjust the number to string cache based on the max semispace size....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527006: - Adjust the number to string cache based on the max semispace size.... (Closed)

Created:
10 years, 11 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Adjust the number to string cache based on the max semispace size. Flushed at compacting mark sweep. - Simplified FindEntry by eliminating the counter.

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -43 lines)
M	src/heap.h	View	2 chunks	+6 lines, -3 lines	0 comments
M	src/heap.cc	View	4 chunks	+32 lines, -12 lines	1 comment
M	src/objects.h	View	1 chunk	+8 lines, -0 lines	0 comments
M	src/objects.cc	View	3 chunks	+21 lines, -28 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 11 months ago (2010-01-06 11:16:00 UTC) #2

LGTM

http://codereview.chromium.org/527006/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/527006/diff/1/2#newcode1611
src/heap.cc:1611: // max_semispace_size_ == 512 KB => number_string_cache_size =
16.
32?

Also, the logic seems different from what the comment suggests.  Update the
comment?

Expand Messages | Collapse Messages