Issue 5269007: Introduce a content settings provider interface.

Issue 5269007: Introduce a content settings provider interface. (Closed)

Created:
10 years ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
markusheintz_, gfeher

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/content_settings

Visibility:
Public.

Description

Introduce a content settings provider interface. BUG=64753 TEST=ContentSettingsProviderTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67707

Patch Set 4 : updates #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -0 lines)			Patch
A	chrome/browser/content_settings/content_settings_provider.h	View	1 2	1 chunk	+38 lines, -0 lines	2 comments	Download
A	chrome/browser/content_settings/content_settings_provider_unittest.cc	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/browser/content_settings/mock_content_settings_provider.h	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/content_settings/mock_content_settings_provider.cc	View	1 2 3	1 chunk	+41 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

gfeher

http://codereview.chromium.org/5269007/diff/3001/chrome/browser/content_settings/content_settings_provider.h File chrome/browser/content_settings/content_settings_provider.h (right): http://codereview.chromium.org/5269007/diff/3001/chrome/browser/content_settings/content_settings_provider.h#newcode16 chrome/browser/content_settings/content_settings_provider.h:16: virtual bool canProvideDefaultSetting(ContentSettingsType content_type) = 0; I think the ...

10 years ago (2010-11-30 12:20:59 UTC) #2

jochen (gone - plz use gerrit)

10 years ago (2010-11-30 12:29:10 UTC) #3

gfeher

http://codereview.chromium.org/5269007/diff/3001/chrome/browser/content_settings/mock_content_settings_provider.cc File chrome/browser/content_settings/mock_content_settings_provider.cc (right): http://codereview.chromium.org/5269007/diff/3001/chrome/browser/content_settings/mock_content_settings_provider.cc#newcode11 chrome/browser/content_settings/mock_content_settings_provider.cc:11: bool can_override) : Shouldn't the colon be in the ...

10 years ago (2010-11-30 12:29:11 UTC) #4

jochen (gone - plz use gerrit)

10 years ago (2010-11-30 12:36:27 UTC) #5

markusheintz_

10 years ago (2010-11-30 14:13:15 UTC) #7

http://codereview.chromium.org/5269007/diff/12001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_provider.h (right):

http://codereview.chromium.org/5269007/diff/12001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_provider.h:16: virtual bool
CanProvideDefaultSetting(ContentSettingsType content_type) = 0;
Might be a stupid question but: Does this method returns true if
CONTENT_SETTING_DEFAULT can be provided? Or if a default setting value can be
provided.

http://codereview.chromium.org/5269007/diff/12001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_provider.h:33: 
What about the non default content settings aka exceptions?

Expand Messages | Collapse Messages