Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 5268006: Changing the security model for "chrome" URLs... (Closed)

Created:
10 years ago by abarth-chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Changing the security model for "chrome" URLs This patch changes the security model for "chrome" URLs to make implementing some features in DOMUI easier. Instead of registering "chrome" as a NoAccess and a Local scheme, we register it as a DisplayIsolated scheme. That should have the effects outlined in this email: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/863700bf99b3f3ed See also https://bugs.webkit.org/show_bug.cgi?id=50182 which introduces the necessary API into WebKit. BUG=69140 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71382

Patch Set 1 #

Patch Set 2 : Changing the security model for "chrome" URLs... #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
The WebKit side of this patch is in the commit-queue. I'll hold off landing this ...
10 years ago (2010-11-30 00:22:38 UTC) #1
use chromium acct.
you can put BUG=57485
10 years ago (2010-11-30 01:26:07 UTC) #2
brettw
LGTM
10 years ago (2010-11-30 04:58:28 UTC) #3
use chromium acct.
Adam, can you commit this? thanks.
10 years ago (2010-12-02 02:26:33 UTC) #4
abarth-chromium
The WebKit patch that this depends on got rolled out because it regressed some perf ...
10 years ago (2010-12-02 02:50:42 UTC) #5
abarth-chromium
9 years, 11 months ago (2011-01-13 21:59:10 UTC) #6
I'm going to land this behind a command-line flag so we can experiment with it.

Powered by Google App Engine
This is Rietveld 408576698