Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 5263007: Should not show autofill drop-down for a user/pw form (Closed)

Created:
10 years ago by dhollowa
Modified:
9 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, James Hawkins, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Should not show autofill drop-down for a user/pw form Changes Autofill popup menu to only show "Clear form..." menu item when form Autofill suggestions are shown. BUG=60805 TEST=Manual, according to bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M chrome/renderer/autofill_helper.cc View 2 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dhollowa
10 years ago (2010-11-30 21:13:34 UTC) #1
Ilya Sherman
This doesn't show the "Clear Form" option when the autofill popup is a warning, e.g. ...
10 years ago (2010-12-01 00:20:39 UTC) #2
dhollowa
On 2010/12/01 00:20:39, Ilya Sherman wrote: > This doesn't show the "Clear Form" option when ...
10 years ago (2010-12-01 00:40:12 UTC) #3
Ilya Sherman
10 years ago (2010-12-01 00:46:46 UTC) #4
On 2010/12/01 00:40:12, dhollowa wrote:
> On 2010/12/01 00:20:39, Ilya Sherman wrote:
> > This doesn't show the "Clear Form" option when the autofill popup is a
> warning,
> > e.g. when you've filled the address part of an http form, and then try to
fill
> > the credit card part.  I thought we'd wanted to still show "Clear Form" in
> this
> > case.
> 
> No, I prefer the warnings to stand alone.  It seems more consistent to me.

Ok, LGTM then

Powered by Google App Engine
This is Rietveld 408576698