Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: webkit/tools/test_shell/test_shell_win.cc

Issue 5262011: TestShell windows: add --crash-dumps-fulldump option (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the feedback Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/test_shell/test_shell_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_shell_win.cc
diff --git a/webkit/tools/test_shell/test_shell_win.cc b/webkit/tools/test_shell/test_shell_win.cc
index 509027161d58224bf0e2d9f35d4b25e3b16d2691..aba23fc6b6eb8634aeeef154a658b74638389016 100644
--- a/webkit/tools/test_shell/test_shell_win.cc
+++ b/webkit/tools/test_shell/test_shell_win.cc
@@ -151,6 +151,11 @@ HINSTANCE TestShell::instance_handle_;
/////////////////////////////////////////////////////////////////////////////
// static methods on TestShell
+const MINIDUMP_TYPE kFullDumpType = static_cast<MINIDUMP_TYPE>(
+ MiniDumpWithFullMemory | // Full memory from process.
+ MiniDumpWithProcessThreadData | // Get PEB and TEB.
+ MiniDumpWithHandleData); // Get all handle information.
+
void TestShell::InitializeTestShell(bool layout_test_mode,
bool allow_external_pages) {
// Start COM stuff.
@@ -180,7 +185,14 @@ void TestShell::InitializeTestShell(bool layout_test_mode,
if (parsed_command_line.HasSwitch(test_shell::kCrashDumps)) {
std::wstring dir(
parsed_command_line.GetSwitchValueNative(test_shell::kCrashDumps));
- new google_breakpad::ExceptionHandler(dir, 0, &MinidumpCallback, 0, true);
+ if (parsed_command_line.HasSwitch(test_shell::kCrashDumpsFulldump)) {
+ new google_breakpad::ExceptionHandler(
+ dir, 0, &MinidumpCallback, 0, true,
+ kFullDumpType, 0, 0);
+ } else {
+ new google_breakpad::ExceptionHandler(
+ dir, 0, &MinidumpCallback, 0, true);
+ }
}
}
« no previous file with comments | « webkit/tools/test_shell/test_shell_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698