Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 5262011: TestShell windows: add --crash-dumps-fulldump option (Closed)

Created:
10 years ago by gmorrita
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

TestShell windows: add --crash-dumps-fulldump option to allow the dump including the heap memory. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67925

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed the feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M webkit/tools/test_shell/test_shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
gmorrita
Hi tony, could you take a look? This flag is added to investigate the test ...
10 years ago (2010-11-30 05:27:57 UTC) #1
tony
Do you plan on running this on the bots? It seems like even for one ...
10 years ago (2010-11-30 17:58:09 UTC) #2
gmorrita
Hi tony, thank you for reviwiewing! This patch is not for a bot. I made ...
10 years ago (2010-12-01 03:36:18 UTC) #3
tony
LGTM. Do you need someone to commit this for you?
10 years ago (2010-12-01 18:09:54 UTC) #4
gmorrita
10 years ago (2010-12-02 00:40:13 UTC) #5
On 2010/12/01 18:09:54, tony wrote:
> LGTM.  Do you need someone to commit this for you?
Thanks! I got a commit right for the gardening so I can commit this by myself.

Powered by Google App Engine
This is Rietveld 408576698