Issue 526002: Finish removing query_helpers.*

Issue 526002: Finish removing query_helpers.* (Closed)

Created:
10 years, 11 months ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Finish removing query_helpers.* BUG=none TEST=Run sync_unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35765

Patch Set 5 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1009 lines)			Patch
M	chrome/browser/sync/syncable/directory_backing_store.cc	View	1 2 3 4	2 chunks	+26 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_unittest.cc	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/browser/sync/util/query_helpers.h	View	1 2 3 4	1 chunk	+0 lines, -695 lines	0 comments	Download
D	chrome/browser/sync/util/query_helpers.cc	View	1 2 3 4	1 chunk	+0 lines, -263 lines	0 comments	Download
D	chrome/browser/sync/util/query_helpers_unittest.cc	View	4	1 chunk	+0 lines, -45 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

LGTM http://codereview.chromium.org/526002/diff/4001/5001 File chrome/browser/sync/syncable/directory_backing_store.cc (right): http://codereview.chromium.org/526002/diff/4001/5001#newcode170 chrome/browser/sync/syncable/directory_backing_store.cc:170: { Maybe we should add TODOs to investigate ...

10 years, 11 months ago (2010-01-05 23:06:54 UTC) #2

Zachary Kuznia

10 years, 11 months ago (2010-01-06 00:12:19 UTC) #3

http://codereview.chromium.org/526002/diff/4001/5001
File chrome/browser/sync/syncable/directory_backing_store.cc (right):

http://codereview.chromium.org/526002/diff/4001/5001#newcode170
chrome/browser/sync/syncable/directory_backing_store.cc:170: {
On 2010/01/05 23:06:54, nick wrote:
> Maybe we should add TODOs to investigate whether these three tweaks are
> necessary.  It seems that if they are, it would be worthwhile to do so for the
> other Chrome databases as well.  WDYT?

I'll actually be removing fullfsync in another changelist, as it only affects
MacOS and it is advised not to use it.  I'll look into the other pragma while
I'm fixing the return value checking on sqlite calls.

Expand Messages | Collapse Messages