Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 5259007: Undo removal of chrome_dll_version from r67457. (Closed)

Created:
10 years ago by Jói
Modified:
9 years, 7 months ago
Reviewers:
robertshield, M-A Ruel
CC:
chromium-reviews, amit, Paweł Hajdan Jr., ben+cc_chromium.org
Visibility:
Public.

Description

Undo removal of chrome_dll_version from r67457. This is not a straight revert as we keep the part where chrome.dll directly includes the generated .rc file instead of having it included via chrome_dll.rc, as that seems to cause other dependency issues. BUG=none TEST=it builds, incremental builds on changes to chrome/VERSION work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67657

Patch Set 1 #

Patch Set 2 : merge origin #

Total comments: 2

Patch Set 3 : make tests depend on version rc directly #

Patch Set 4 : remove double dependency #

Patch Set 5 : touch chrome_dll.rc to help ensure first incremental build after this check-in succeeds #

Patch Set 6 : merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -78 lines) Patch
M chrome/app/chrome_dll.rc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
D chrome/app/chrome_dll_version.rc View 1 chunk +0 lines, -44 lines 0 comments Download
A chrome/app/chrome_dll_version.rc.version View 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 20 chunks +33 lines, -21 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jói
10 years ago (2010-11-29 22:39:49 UTC) #1
robertshield
LGTM nits, ignore if doing a straight revert http://codereview.chromium.org/5259007/diff/2001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/5259007/diff/2001/chrome/chrome_tests.gypi#newcode31 chrome/chrome_tests.gypi:31: 'browser/sync/protocol/sync_proto.gyp:sync_proto_cpp', ...
10 years ago (2010-11-29 22:43:29 UTC) #2
Jói
Marc-Antoine, if you wouldn't mind taking a look at the delta from patch 1 (Robert ...
10 years ago (2010-11-29 23:14:21 UTC) #3
M-A Ruel
10 years ago (2010-11-30 01:00:41 UTC) #4
Diff between patchset 1 and 5 lgtm.

Powered by Google App Engine
This is Rietveld 408576698