Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2955)

Unified Diff: ceee/ie/plugin/bho/browser_helper_object.cc

Issue 5258006: Restart of ceee_broker on crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ceee/ie/plugin/bho/browser_helper_object.cc
===================================================================
--- ceee/ie/plugin/bho/browser_helper_object.cc (revision 67655)
+++ ceee/ie/plugin/bho/browser_helper_object.cc (working copy)
@@ -102,6 +102,7 @@
thread_id_(::GetCurrentThreadId()),
full_tab_chrome_frame_(false),
broker_client_queue_(this),
+ broker_rpc_(false),
tab_events_funnel_(broker_client()) {
TRACE_EVENT_BEGIN("ceee.bho", this, "");
}
@@ -840,7 +841,7 @@
HRESULT BrowserHelperObject::PostMessageImpl(int port_id,
const std::string& message) {
- return extension_port_manager_.PostMessage(port_id, message);
+ return extension_port_manager_.PostMessage(port_id, message);
}
HRESULT BrowserHelperObject::OnCfPrivateMessage(BSTR msg,
@@ -955,7 +956,7 @@
HandleNavigateComplete(webbrowser, url_bstr);
for (std::vector<Sink*>::iterator iter = sinks_.begin();
- iter != sinks_.end(); ++iter) {
+ iter != sinks_.end(); ++iter) {
(*iter)->OnNavigateComplete(webbrowser, url_bstr);
Sigurður Ásgeirsson 2010/12/01 14:23:54 nit: indent -1
MAD 2010/12/01 16:35:23 Actually, -1 for "iter !=" and -2 for "(*iter)->"
Vitaly Buka corp 2010/12/01 19:06:04 That is strange. I didn't touch this code. I'll fi
}
}
@@ -1379,7 +1380,7 @@
READYSTATE old_state = lower_bound_ready_state_;
READYSTATE new_state = new_lowest_ready_state;
if (old_state == new_state)
- return S_OK;
+ return S_OK;
Sigurður Ásgeirsson 2010/12/01 14:23:54 nit: indent +2
Vitaly Buka corp 2010/12/01 19:06:04 Same here. On 2010/12/01 14:23:54, Ruðrugis wrote:
// Remember the new lowest ready state as our current one.
lower_bound_ready_state_ = new_state;

Powered by Google App Engine
This is Rietveld 408576698