Issue 5256004: Expose an API method for getting JSObject constructor name

Issue 5256004: Expose an API method for getting JSObject constructor name (Closed)

Created:
10 years, 1 month ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive), Vitaly Repeshko, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Expose a method for getting JSObject constructor name Committed: http://code.google.com/p/v8/source/detail?r=5890

Patch Set 5 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -8 lines)			Patch
M	include/v8.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/heap-profiler.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/profile-generator.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/profile-generator.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 3	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

Drive by nit. Getter should have "Get" prefix. -- Vitaly

10 years, 1 month ago (2010-11-24 17:26:07 UTC) #2

Vitaly Repeshko

Drive by nit. Getter should have "Get" prefix. -- Vitaly

10 years, 1 month ago (2010-11-24 17:26:07 UTC) #3

yurys

Done. On 2010/11/24 17:26:07, Vitaly wrote: > Drive by nit. Getter should have "Get" prefix. ...

10 years, 1 month ago (2010-11-24 17:32:27 UTC) #4

mnaganov (inactive)

LGTM http://codereview.chromium.org/5256004/diff/25001/include/v8.h File include/v8.h (right): http://codereview.chromium.org/5256004/diff/25001/include/v8.h#newcode1543 include/v8.h:1543: * Returns name of the function that created ...

10 years ago (2010-11-24 20:41:10 UTC) #5

yurys

10 years ago (2010-11-25 08:03:45 UTC) #6

http://codereview.chromium.org/5256004/diff/25001/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/5256004/diff/25001/include/v8.h#newcode1543
include/v8.h:1543: * Returns name of the function that created this object.
On 2010/11/24 20:41:11, Michail Naganov wrote:
> I'd rephrase this as: "Returns the name of the function invoked as a
constructor
> for this object."

Done.

Expand Messages | Collapse Messages