Issue 5254012: Always use persistent profile for CF+CEEE installs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5254012: Always use persistent profile for CF+CEEE installs. (Closed)

Created:
10 years ago by Jói

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews, amit, Paweł Hajdan Jr., ceee-reviews_chromium.org, vrk (LEFT CHROMIUM), Alexander Potapenko, John Grabowski, annacc, stuartmorgan+watch_chromium.org, native-client-reviews_googlegroups.com, dhollowa, cbentzel+watch_chromium.org, fbarchard, nkostylev+cc_chromium.org, Alpha Left Google, ddorwin+watch_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org, ben+cc_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org, awong, Timur Iskhodzhanov, James Hawkins, scherkus (not reviewing), Nirnimesh, acolwell GONE FROM CHROMIUM, anantha, dyu1, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -11 lines)			Patch
A	ceee/ie/common/ceee_util.h	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	ceee/ie/common/ceee_util.cc	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
A	ceee/ie/common/ceee_util_unittest.cc	View		1 chunk	+55 lines, -0 lines	0 comments	Download
M	ceee/ie/common/common.gyp	View	1	1 chunk	+9 lines, -7 lines	0 comments	Download
M	ceee/ie/ie.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex_base.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

Amit, quick fix as discussed. Leaving a couple of TODOs to limit changes as this ...

10 years ago (2010-11-30 23:51:32 UTC) #1

amit

10 years ago (2010-12-01 02:08:42 UTC) #2

lgtm

http://codereview.chromium.org/5254012/diff/1/ceee/ie/common/ceee_util.cc
File ceee/ie/common/ceee_util.cc (right):

http://codereview.chromium.org/5254012/diff/1/ceee/ie/common/ceee_util.cc#new...
ceee/ie/common/ceee_util.cc:26: return key.Open(HKEY_CLASSES_ROOT, path.c_str(),
KEY_READ);
nit: KEY_QUERY_VALUE or SYNCHRONIZE? since you are checking only for existence?
KEY_READ is a dense combination.

Expand Messages | Collapse Messages

Issue 5254012: Always use persistent profile for CF+CEEE installs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : merge to head, address Amit's nit #

Messages