Forward unhandled KeyEvents to WidgetGtk's HandleKeyboardEvent() in native textfields.

views/controls/textfield/native_textfield_gtk.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <gtk/gtk.h>
 
 #include "views/controls/textfield/native_textfield_gtk.h"
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
@@ skipping 343 matching lines @@
 gboolean NativeTextfieldGtk::OnKeyPressEvent(GdkEventKey* event) {
   Textfield::Controller* controller = textfield_->GetController();
   if (controller) {
     Textfield::Keystroke ks(event);
     return controller->HandleKeystroke(textfield_, ks);
   }
   return false;
 }
 
 // static
+gboolean NativeTextfieldGtk::OnActivateHandler(
+    GtkWidget* widget,
+    NativeTextfieldGtk* textfield) {
+  return textfield->OnActivate();
+}
+
+gboolean NativeTextfieldGtk::OnActivate() {
+  return textfield_->GetParent()->AcceleratorPressed(
+      Accelerator(app::VKEY_RETURN, false, false, false));

[James Su, 2010/12/01 18:35:56]

It's probably better to call the widget's HandleKeyboardEvent() method with the
current gdk event (if it's a keyboard event).
In case the accelerator is handled elsewhere.

+}
+
+// static
 gboolean NativeTextfieldGtk::OnChangedHandler(
     GtkWidget* widget,
     NativeTextfieldGtk* textfield) {
   return textfield->OnChanged();
 }
 
 gboolean NativeTextfieldGtk::OnChanged() {
   textfield_->SyncText();
   Textfield::Controller* controller = textfield_->GetController();
   if (controller)
@@ skipping 28 matching lines @@
     GtkTextBuffer* text_buffer = gtk_text_view_get_buffer(
         GTK_TEXT_VIEW(widget));
     g_signal_connect(text_buffer, "changed",
                      G_CALLBACK(OnChangedHandler), this);
   } else {
     g_signal_connect(widget, "changed",
                      G_CALLBACK(OnChangedHandler), this);
   }
   g_signal_connect(widget, "key-press-event",
                    G_CALLBACK(OnKeyPressEventHandler), this);
+  // In order to properly trigger Accelerators bound to VKEY_RETURN, we need to
+  // send an event when the widget gets the activate signal.
+  g_signal_connect(widget, "activate", G_CALLBACK(&OnActivateHandler), this);

[James Su, 2010/12/01 18:35:56]

Only GtkEntry has "activate" signal.

 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeTextfieldWrapper, public:
 
 // static
 NativeTextfieldWrapper* NativeTextfieldWrapper::CreateWrapper(
     Textfield* field) {
   return new NativeTextfieldGtk(field);
 }
 
 }  // namespace views