Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/common/extensions/api/extension_api.json

Issue 5254007: Addition of 'maxSize' to experimental popup extension API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_api.json
===================================================================
--- chrome/common/extensions/api/extension_api.json (revision 67311)
+++ chrome/common/extensions/api/extension_api.json (working copy)
@@ -2342,6 +2342,26 @@
"description": "Pass 'bubble' to give the pop-up window a bubble-chrome border, including an arrow pointing at the relative-to point. Pass 'rectangle' to give the pop-up a rectangular black border with drop-shadow. Default behaviour is to pass 'bubble'.",
"optional": true,
"enum": ["bubble", "rectangle"]
+ },
+ "maxSize": {
+ "type": "object",
+ "optional": true,
+ "properties": {
+ "width": {
+ "type": "integer",
+ "description": "The maximal width to which the popup will resize. If not present, the popup will be no wider than 800 pixels.",
+ "optional": true,
+ "minimum": 32,
+ "maximum": 1024
Jói 2010/11/25 13:50:30 Do we want to specify a maximum at all? Perhaps th
Jeff Timanus 2010/11/25 23:35:30 I chose this maximum value arbitrarily, after pond
+ },
+ "height": {
+ "type": "integer",
+ "description": "The maximal height to which the popup will resize. If not present, the popup will be no taller than 600 pixels.",
+ "optional": true,
+ "minimum": 32,
+ "maximum": 768
+ }
+ }
}
}
},

Powered by Google App Engine
This is Rietveld 408576698