Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10307)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 5254007: Addition of 'maxSize' to experimental popup extension API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extension_process_bindings.js
===================================================================
--- chrome/renderer/resources/extension_process_bindings.js (revision 67311)
+++ chrome/renderer/resources/extension_process_bindings.js (working copy)
@@ -513,6 +513,18 @@
type: "string",
optional: true,
enum: ["bubble", "rectangle"]
+ },
+ maxSize: {
+ type: "object",
+ optional: true,
+ properties: {
+ width: {
+ type: "integer", optional: true, minimum: 32
+ },
+ height: {
+ type: "integer", optional: true, minimum: 32
+ }
+ }
}
}
},
@@ -523,7 +535,8 @@
{
domAnchor: getAbsoluteRect(showDetails.relativeTo),
giveFocus: showDetails.giveFocus,
- borderStyle: showDetails.borderStyle
+ borderStyle: showDetails.borderStyle,
+ maxSize: showDetails.maxSize
},
callback],
internalSchema);
« no previous file with comments | « chrome/common/extensions/api/extension_api.json ('k') | chrome/test/data/extensions/api_test/popup/popup_main/dom_ui.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698