Issue 525105: Fixes bug in WidgetGtk. WidgetGtk::GetBounds can end up crashing. I...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 525105: Fixes bug in WidgetGtk. WidgetGtk::GetBounds can end up crashing. I... (Closed)

Created:
10 years, 11 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes bug in WidgetGtk. WidgetGtk::GetBounds can end up crashing. I believe returning a location of 0x0 is effectively what Windows does too in this situation. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35805

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	views/widget/widget_gtk.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2010/01/08 01:10:11, sky wrote:
>

Expand Messages | Collapse Messages