Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 525083: Added an application framework for demos. This framework currently only suppo... (Closed)

Created:
10 years, 11 months ago by alokp
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, apatrick_chromium
Visibility:
Public.

Description

Added an application framework for demos. This framework currently only supports stand-alone apps. It will be extended to support trusted pepper and untrusted nacl apps. BUG=26099 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35758

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -0 lines) Patch
A gpu/demos/app_framework/application.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A gpu/demos/app_framework/application.cc View 1 chunk +161 lines, -0 lines 0 comments Download
A gpu/demos/app_framework/platform.h View 1 chunk +23 lines, -0 lines 0 comments Download
A gpu/demos/demos.gyp View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alokp
10 years, 11 months ago (2010-01-07 05:41:48 UTC) #1
vangelis
some nits http://codereview.chromium.org/525083/diff/1/6 File gpu/demos/app_framework/application.h (right): http://codereview.chromium.org/525083/diff/1/6#newcode32 gpu/demos/app_framework/application.h:32: // Returns the size of rendering surface. ...
10 years, 11 months ago (2010-01-07 19:15:33 UTC) #2
alokp
http://codereview.chromium.org/525083/diff/1/6 File gpu/demos/app_framework/application.h (right): http://codereview.chromium.org/525083/diff/1/6#newcode32 gpu/demos/app_framework/application.h:32: // Returns the size of rendering surface. On 2010/01/07 ...
10 years, 11 months ago (2010-01-07 20:37:04 UTC) #3
vangelis
10 years, 11 months ago (2010-01-07 23:15:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698