src/utils.cc - Issue 525064: Fixed potential length miscalculations by limiting max size of arrays and strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.cc

Issue 525064: Fixed potential length miscalculations by limiting max size of arrays and strings. (Closed)

Patch Set: Added (unrelated) cast to make Win64 compile. Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils.cc

diff --git a/src/utils.cc b/src/utils.cc

index 08ee16ff26800a019ecc56e04d73aa857a354ace..374385b67b1f1799a08efc1a3f5b10db5b09c2c0 100644

--- a/src/utils.cc

+++ b/src/utils.cc

@@ -40,6 +40,7 @@ namespace internal {

// Implementation is from "Hacker's Delight" by Henry S. Warren, Jr.,

// figure 3-3, page 48, where the function is called clp2.

uint32_t RoundUpToPowerOf2(uint32_t x) {

+ ASSERT(x <= 0x80000000u);

x = x - 1;

x = x | (x >> 1);

x = x | (x >> 2);

« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »