Issue 525046: Build and install a Chromium OS specific version of upstart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 525046: Build and install a Chromium OS specific version of upstart. (Closed)

Created:
10 years, 11 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Build and install a Chromium OS specific version of upstart.

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -4 lines)			Patch
M	.gitignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	DEPS	View	2 chunks	+4 lines, -2 lines	1 comment	Download
M	src/package_repo/package-list-prod.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/scripts/build_platform_packages.sh	View	1 chunk	+3 lines, -2 lines	0 comments	Download
A	src/third_party/upstart/LICENSE	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/third_party/upstart/README.chromium	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 11 months ago (2010-01-06 05:27:46 UTC) #2

LGTM

I don't see a metadata.chromium file but I don't see it any of the other recent
repos. I guess we've decided not to do that anymore...

http://codereview.chromium.org/525046/diff/1/3
File DEPS (right):

http://codereview.chromium.org/525046/diff/1/3#newcode138
DEPS:138: _third_party_base + "upstart/files" : "/upstart.git",
Extra space before the colon. If you fix it, could please fix the same issue
with the autotest repo line. Also, most packages don't do .../files anymore --
this seems kind of random at this point.

Expand Messages | Collapse Messages