Issue 525025: Merge r3536 and r3538 to trunk to fix performance issue with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 525025: Merge r3536 and r3538 to trunk to fix performance issue with (Closed)

Created:
10 years, 11 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Merge r3536 and r3538 to trunk to fix performance issue with hash tables. Committed: http://code.google.com/p/v8/source/detail?r=3539

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -12 lines)			Patch
M	src/objects.h	View	4 chunks	+24 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+9 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

I suggest merging the hash table optimizations to trunk and later to Chromium -- assuming ...

10 years, 11 months ago (2010-01-05 12:49:07 UTC) #1

Mads Ager (chromium)

10 years, 11 months ago (2010-01-05 13:11:51 UTC) #2

On 2010/01/05 12:49:07, Kasper Lund wrote:
> I suggest merging the hash table optimizations to trunk and later to Chromium
--
> assuming that the two changes pass all our tests. What do you think?

I agree, thanks!  LGTM.

Expand Messages | Collapse Messages