Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 5241001: AutoFillField::set_heuristic_type: don't try to handle a DCHECK failure (Closed)

Created:
10 years, 1 month ago by Ilya Sherman
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, ben+cc_chromium.org, James Hawkins, dhollowa
Visibility:
Public.

Description

AutoFillField::set_heuristic_type: avoid redundant logic in DCHECK Just a bit of code cleanup BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69048

Patch Set 1 #

Patch Set 2 : Slightly clearer then #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/autofill/autofill_field.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
10 years, 1 month ago (2010-11-19 08:08:48 UTC) #1
dhollowa
We should leave this as-is. DCHECK is there for debug builds only so we won't ...
10 years, 1 month ago (2010-11-19 16:42:36 UTC) #2
Ilya Sherman
On 2010/11/19 16:42:36, dhollowa wrote: > We should leave this as-is. DCHECK is there for ...
10 years ago (2010-12-02 01:22:14 UTC) #3
Ilya Sherman
ping
10 years ago (2010-12-11 04:25:32 UTC) #4
dhollowa
10 years ago (2010-12-12 06:58:34 UTC) #5
LGTM.  Thanks.

Powered by Google App Engine
This is Rietveld 408576698