Issue 524073: Consistently pass through PKG_CONFIG_LIBDIR environment variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 524073: Consistently pass through PKG_CONFIG_LIBDIR environment variable (Closed)

Created:
10 years, 11 months ago by cjwatson

Modified:
9 years, 7 months ago

Reviewers:
bdavirro, tedbo, Bill Richardson

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Consistently pass through PKG_CONFIG_LIBDIR environment variable PKG_CONFIG_LIBDIR is set by dpkg-buildpackage, and needs to be passed through to pkg-config for successful cross-building.

Patch Set 1 #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -4 lines)			Patch
M	src/common/SConstruct	View	1 chunk	+3 lines, -2 lines	2 comments	Download
M	src/platform/theme/SConstruct	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/platform/update_engine/SConstruct	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/platform/window_manager/SConstruct	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tedbo

LGTM One recommendation below: http://codereview.chromium.org/524073/diff/1/2 File src/common/SConstruct (right): http://codereview.chromium.org/524073/diff/1/2#newcode21 src/common/SConstruct:21: # Fix up the pkg-config ...

10 years, 11 months ago (2010-01-08 18:03:24 UTC) #2

cjwatson

10 years, 11 months ago (2010-01-08 18:57:01 UTC) #3

http://codereview.chromium.org/524073/diff/1/2
File src/common/SConstruct (right):

http://codereview.chromium.org/524073/diff/1/2#newcode21
src/common/SConstruct:21: # Fix up the pkg-config path if it is present in the
environment.
On 2010/01/08 18:03:24, tedbo wrote:
> Please fix up the comment as well. Could be:
> 
> # Fix issue with scons not passing pkg-config vars through the environment.

Done for all files. Thanks.

Expand Messages | Collapse Messages