Issue 524057: Fix a bug of unnecessary "Confirm form resubmission" dialog....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 524057: Fix a bug of unnecessary "Confirm form resubmission" dialog.... (Closed)

Created:
10 years, 11 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a bug of unnecessary "Confirm form resubmission" dialog. If a URL is requested by the POST method and then the page is redirected to another URL, NavigationEntry::has_post_data_ is not cleared correctly with the prior code. So "Confirm form resubmission" dialog is shown when a user asks reloading the redirected page. TEST=Add a unit test BUG=21245 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35770

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -0 lines)			Patch
	M	chrome/browser/tab_contents/navigation_controller.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/tab_contents/navigation_controller_unittest.cc	View		1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Very nice, thanks for the good test. LGTM

Expand Messages | Collapse Messages