Issue 524051: Revert 35649 - Make Pepper plugins work on Linux....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 524051: Revert 35649 - Make Pepper plugins work on Linux.... (Closed)

Created:
10 years, 11 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 35649 - Make Pepper plugins work on Linux. fix pepper_test_plugin so that it is loaded on Linux remove skia & base dependency in test plugin so that it can be compiled with fPIC remove ifdef WIN in pepper code Patch by neb@chromium.org Original review: http://codereview.chromium.org/501124/show BUG=none TEST=none TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35653

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -111 lines)			Patch
M	build/all.gyp	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_pepper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/pepper_test_plugin/event_handler.cc	View	4 chunks	+28 lines, -25 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/main.cc	View	5 chunks	+23 lines, -27 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/plugin_object.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/plugin_object.cc	View	7 chunks	+10 lines, -34 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM, sorry.