Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: build/common.gypi

Issue 524015: linux: reenable symbols in backtraces in debug builds (Closed)
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 858ff62983bf4d9b7e7c6c84b4983b809cb1f13c..09cf39715399d849c32ecd9e1c12a25adbca65ed 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -586,7 +586,6 @@
'<(werror)', # See note above about the werror variable.
'-pthread',
'-fno-exceptions',
- '-fvisibility=hidden',
'-Wall',
'-D_FILE_OFFSET_BITS=64',
],
@@ -698,6 +697,10 @@
# can be removed at link time with --gc-sections.
'-fdata-sections',
'-ffunction-sections',
+ # Don't export any symbols (for example, to plugins we dlopen()).
+ # This must be in Release builds only because otherwise we don't
+ # get backtraces.
+ '-fvisibility=hidden',
# We don't use exceptions. The eh_frame section is used for those
# and for symbolizing backtraces. By passing this flag we drop
# the eh_frame section completely, we shaving off 2.5mb from
« no previous file with comments | « base/debug_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698