Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 524009: Added pause button to DownloadItemMac via IB and IBAction to receive the even... (Closed)

Created:
10 years, 11 months ago by sig11
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Added pause button to DownloadItemMac via IB and IBAction to receive the event. BUG=23069 TEST=Download large file, click pause in download item's menu to pause/unpause. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+767 lines, -39 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/nibs/DownloadItem.xib View 24 chunks +758 lines, -39 lines 0 comments Download
M chrome/browser/cocoa/download_item_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/download_item_controller.mm View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Looks like a great start, thanks! Linux shows a check mark in front of "Pause" ...
10 years, 11 months ago (2009-12-30 18:12:46 UTC) #1
sig11
On 2009/12/30 18:12:46, Nico wrote: > Looks like a great start, thanks! > > Linux ...
10 years, 11 months ago (2009-12-30 18:16:36 UTC) #2
Nico
LGTM then. I'll send it to the try servers.
10 years, 11 months ago (2009-12-30 18:19:41 UTC) #3
Nico
I patched this in and played with it a bit. It looks like linux shows ...
10 years, 11 months ago (2009-12-30 18:45:58 UTC) #4
Nico
10 years, 11 months ago (2009-12-30 18:49:28 UTC) #5
OTOH, chrome://downloads does not display the disk while a download is paused,
so I think the current patch is good as is. Sorry :-)

Powered by Google App Engine
This is Rietveld 408576698