[Sync] Make sync integration tests use local xmpp servers.

[Sync] Make sync integration tests use local xmpp servers.

Fixed signed/unsigned bug with the port number.

BUG=53934
TEST=sync integration tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67491

[akalin, 2010-11-19 02:40:50]

+cbentzel, +pawel, and +rsimha for review (this depends on
http://codereview.chromium.org/5196001/ and
http://codereview.chromium.org/5104004/ )

[Raghu Simha, 2010-11-19 03:22:11]

live_sync changes LGTM.

[cbentzel, 2010-11-19 15:46:24]

LGTM

Pawel is the best person to decide whether server_data() should be added to the
TestServer API.

http://codereview.chromium.org/5239001/diff/1/chrome/test/live_sync/live_sync...
File chrome/test/live_sync/live_sync_test.cc (right):

http://codereview.chromium.org/5239001/diff/1/chrome/test/live_sync/live_sync...
chrome/test/live_sync/live_sync_test.cc:342: if ((xmpp_port <= 0) || (xmpp_port
>= kuint16max)) {
This is in two locations now - should you have an abstraction for getting a port
from the dictionaryvalue?

[Paweł Hajdan Jr., 2010-11-19 20:56:15]

LGTM

[akalin, 2010-11-27 04:38:53]

On 2010/11/19 15:46:24, cbentzel wrote:
> This is in two locations now - should you have an abstraction for getting a
port
> from the dictionaryvalue?

Yeah, although I'm not sure where the best place would be.  Will send out a
separate CL.