Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/browser_navigator.h

Issue 5238002: Reintegrate 552 r66225-r66645.... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/552d/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/browser_navigator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_navigator.h
===================================================================
--- chrome/browser/browser_navigator.h (revision 66837)
+++ chrome/browser/browser_navigator.h (working copy)
@@ -85,6 +85,13 @@
// The disposition requested by the navigation source. Default is
// CURRENT_TAB.
+ // If disposition is NEW_WINDOW or NEW_POPUP, |show_window| is set to true
+ // automatically.
+ // If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_SELECTED is
+ // removed from |tabstrip_add_types| automatically.
+ // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or
+ // SINGLETON_TAB, then TabStripModel::ADD_SELECTED is automatically added to
+ // |tabstrip_add_types|.
WindowOpenDisposition disposition;
// The transition type of the navigation. Default is PageTransition::LINK
@@ -114,6 +121,8 @@
// True if the target window should be made visible at the end of the call
// to Navigate(). Default is false.
+ // If disposition is NEW_WINDOW or NEW_POPUP, |show_window| is set to true
+ // automatically.
bool show_window;
// [in] Specifies a Browser object where the navigation could occur or the
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/browser_navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698