Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 5233002: Add c/dev/ppb_widget_dev.h and cpp/non_thread_safe_ref_count.h to ppapi.gyp. ... (Closed)

Created:
10 years, 1 month ago by dmichael(do not use this one)
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add c/dev/ppb_widget_dev.h and cpp/non_thread_safe_ref_count.h to ppapi.gyp. Add a simple test to ensure all C++ files compile. Re-sorted the includes in test_c_includes.c that uncovered a problem whereby ppapi headers expect pp_stdint.h to include stddef.h, and it wasn't doing it on Windows. See http://codereview.chromium.org/5190004/ for an attempt at automating the test generation and verification of ppapi.gyp. BUG=66321 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -30 lines) Patch
M ppapi/c/pp_stdint.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/ppapi.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M ppapi/tests/test_c_includes.c View 2 chunks +29 lines, -29 lines 0 comments Download
A ppapi/tests/test_cc_includes.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael(do not use this one)
So... the part about updating ppapi.gyp in http://codereview.chromium.org/5190004/ is pretty high priority. So since I ...
10 years, 1 month ago (2010-11-19 15:32:24 UTC) #1
dmichael(do not use this one)
10 years, 1 month ago (2010-11-19 18:11:43 UTC) #2
David Springer
LGTM.
10 years, 1 month ago (2010-11-19 18:12:47 UTC) #3
neb
10 years, 1 month ago (2010-11-19 18:16:49 UTC) #4
LGTM2.

Powered by Google App Engine
This is Rietveld 408576698