git svn --version doesn't work when called outside a git checkout.

git svn --version doesn't work when called outside a git checkout.

TEST=none
BUG=none
TBR=nasser

[Nasser Grainawi, 2010-01-08 18:09:57]

I guess that's why there was that test git clone in the original version. :)

On 2010/01/08 18:06:34, Marc-Antoine Ruel wrote:
>

[Nasser Grainawi, 2010-01-08 18:10:30]

Sorry, didn't publish before.

http://codereview.chromium.org/523166/diff/1/2
File gclient (right):

http://codereview.chromium.org/523166/diff/1/2#newcode46
gclient:46: #test_git_svn
what if we cd to $base_dir first? Since we just verified that it has a .git, all
the commands should work.

[chase, 2010-01-08 20:22:13]

> I guess that's why there was that test git clone in
> the original version. :)

If you're referring to create-chromium-git-src, yes, that's why
the git clone of hello-world.git is necessary, but I could have
probably just created an empty directory, run git init, etc
instead of cloning.

On 2010/01/08 18:10:30, Nasser Grainawi wrote:
> Sorry, didn't publish before.
> 
> http://codereview.chromium.org/523166/diff/1/2
> File gclient (right):
> 
> http://codereview.chromium.org/523166/diff/1/2#newcode46
> gclient:46: #test_git_svn
> what if we cd to $base_dir first? Since we just verified that it has a .git,
all
> the commands should work.

Changing to the checkout directory as a fix makes the most sense to me.

[Nasser Grainawi, 2010-01-08 20:26:29]

chase@chromium.org wrote:
>> I guess that's why there was that test git clone in
>> the original version. :)
> 
> If you're referring to create-chromium-git-src, yes, that's why
> the git clone of hello-world.git is necessary, but I could have
> probably just created an empty directory, run git init, etc
> instead of cloning.
> 
> On 2010/01/08 18:10:30, Nasser Grainawi wrote:
>> Sorry, didn't publish before.
> 
>> http://codereview.chromium.org/523166/diff/1/2
>> File gclient (right):
> 
>> http://codereview.chromium.org/523166/diff/1/2#newcode46
>> gclient:46: #test_git_svn
>> what if we cd to $base_dir first? Since we just verified that it has a 
>> .git,
> all
>> the commands should work.
> 
> Changing to the checkout directory as a fix makes the most sense to me.
> 

I agree, see http://codereview.chromium.org/530001